-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate OwncloudClient - Sharing #1294
base: master
Are you sure you want to change the base?
Conversation
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
d29612c
to
2601614
Compare
2601614
to
d021d74
Compare
fab660b
to
3153281
Compare
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
e6e17ea
to
427bb24
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1294 +/- ##
============================================
- Coverage 49.20% 48.11% -1.09%
- Complexity 1001 1004 +3
============================================
Files 208 208
Lines 7819 8052 +233
Branches 1017 1057 +40
============================================
+ Hits 3847 3874 +27
- Misses 3419 3613 +194
- Partials 553 565 +12
|
This is one of a series of pull requests which aim to replace all instances of
OwnCloudClient
withNextcloudClient
. The reason for this change is that the newerNextcloudClient
uses OkHttp, replacing the outdated Jackrabbit methods.Specifically, this pull request implements the following: