Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate OwncloudClient - Sharing #1294

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Deprecate OwncloudClient - Sharing #1294

wants to merge 14 commits into from

Conversation

ZetaTom
Copy link
Contributor

@ZetaTom ZetaTom commented Jan 10, 2024

This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.

Specifically, this pull request implements the following:

  • changes related to sharing
  • server status and info operations

@ZetaTom ZetaTom self-assigned this Jan 10, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Copy link
Contributor

github-actions bot commented Jun 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3433
Dodgy code2628
Internationalization66
Malicious code vulnerability4950
Multithreaded correctness33
Performance88
Total161163

SpotBugs increased!

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3433
Dodgy code2628
Internationalization66
Malicious code vulnerability4950
Multithreaded correctness33
Performance88
Total161163

SpotBugs increased!

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3435
Dodgy code2629
Internationalization66
Malicious code vulnerability4951
Multithreaded correctness33
Performance88
Total161167

SpotBugs increased!

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3435
Dodgy code2629
Internationalization66
Malicious code vulnerability4951
Multithreaded correctness33
Performance88
Total161167

SpotBugs increased!

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3435
Dodgy code2629
Internationalization66
Malicious code vulnerability4951
Multithreaded correctness33
Performance88
Total161167

SpotBugs increased!

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3435
Dodgy code2629
Internationalization66
Malicious code vulnerability4951
Multithreaded correctness33
Performance88
Total161167

SpotBugs increased!

ZetaTom and others added 10 commits June 25, 2024 08:35
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: ZetaTom <70907959+ZetaTom@users.noreply.github.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3435
Dodgy code2629
Internationalization66
Malicious code vulnerability4951
Multithreaded correctness33
Performance88
Total161167

SpotBugs increased!

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3433
Dodgy code2627
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 27.55906% with 184 lines in your changes missing coverage. Please review.

Project coverage is 48.11%. Comparing base (0c3c568) to head (fa63146).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1294      +/-   ##
============================================
- Coverage     49.20%   48.11%   -1.09%     
- Complexity     1001     1004       +3     
============================================
  Files           208      208              
  Lines          7819     8052     +233     
  Branches       1017     1057      +40     
============================================
+ Hits           3847     3874      +27     
- Misses         3419     3613     +194     
- Partials        553      565      +12     
Files Coverage Δ
...loud/android/lib/common/accounts/AccountUtils.java 5.00% <ø> (ø)
...cloud/android/lib/resources/shares/ShareUtils.java 33.33% <100.00%> (+33.33%) ⬆️
...droid/lib/common/OwnCloudAnonymousCredentials.java 37.50% <0.00%> (ø)
...b/resources/shares/CreateShareRemoteOperation.java 68.53% <82.35%> (-11.47%) ⬇️
...lib/resources/shares/GetSharesRemoteOperation.java 67.39% <72.72%> (-7.61%) ⬇️
...om/owncloud/android/lib/common/OwnCloudClient.java 40.95% <12.50%> (-3.49%) ⬇️
...b/resources/shares/RemoveShareRemoteOperation.java 39.47% <11.11%> (-28.71%) ⬇️
.../lib/resources/shares/GetShareRemoteOperation.java 38.09% <19.04%> (-32.74%) ⬇️
...ources/shares/GetSharesForFileRemoteOperation.java 0.00% <0.00%> (ø)
...b/resources/shares/UpdateShareRemoteOperation.java 33.60% <32.14%> (-26.97%) ⬇️
... and 1 more

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants