migrate CheckRemoteWipeRemoteOperation to NextcloudClient #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1472 +/- ##
============================================
+ Coverage 49.18% 49.34% +0.16%
- Complexity 1001 1004 +3
============================================
Files 208 208
Lines 7817 7820 +3
Branches 1016 1016
============================================
+ Hits 3845 3859 +14
+ Misses 3419 3406 -13
- Partials 553 555 +2
|
ZetaTom
reviewed
Jun 26, 2024
| @@ -89,7 +90,7 @@ public static void beforeAll() throws InterruptedException, | |||
|
|
|||
| url = Uri.parse(arguments.getString("TEST_SERVER_URL")); | |||
| String loginName = arguments.getString("TEST_SERVER_USERNAME"); | |||
| String password = arguments.getString("TEST_SERVER_PASSWORD"); | |||
| password = arguments.getString("TEST_SERVER_PASSWORD"); | |||
There was a problem hiding this comment.
I'm not sure why this variable was made static.
Comment on lines
69
to
+72
| if (json.getBoolean(WIPE)) { | ||
| result = new RemoteOperationResult(true, postMethod); | ||
| result = new RemoteOperationResult<>(true, postMethod); | ||
| } else { | ||
| result = new RemoteOperationResult(false, postMethod); | ||
| result = new RemoteOperationResult<>(false, postMethod); |
There was a problem hiding this comment.
If I'm not mistaken, this if statement can be simplified to the following expression:
result = new RemoteOperationResult<>(json.getBoolean(WIPE), postMethod);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.