Inject Session Time Out To The Remote Operation Constructors #1597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
requested review from
ZetaTom,
AndyScherzinger and
tobiasKaminsky
Signed-off-by: alperozturk <alper_ozturk@proton.me>
AndyScherzinger
previously approved these changes
Nov 27, 2024
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3596-IT-stable-09-28/debug/ |
|
Failing test is unrelated. Example merged PR: #1593 |
ZetaTom
reviewed
Nov 28, 2024
library/src/main/java/com/owncloud/android/lib/resources/e2ee/StoreMetadataV2RemoteOperation.kt
Show resolved
Hide resolved
library/src/main/java/com/owncloud/android/lib/resources/files/CreateFolderRemoteOperation.java
Outdated
Show resolved
Hide resolved
library/src/main/java/com/owncloud/android/lib/resources/files/RemoveFileRemoteOperation.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/owncloud/android/lib/resources/files/RestoreFileVersionRemoteOperation.java
Outdated
Show resolved
Hide resolved
...main/java/com/owncloud/android/lib/resources/trashbin/RemoveTrashbinFileRemoteOperation.java
Outdated
Show resolved
Hide resolved
...ain/java/com/owncloud/android/lib/resources/trashbin/RestoreTrashbinFileRemoteOperation.java
Outdated
Show resolved
Hide resolved
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3603-IT-master-15-50/debug/ |
|
stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/3603-IT-stable-15-53/debug/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client must be able to modify the session timeout according to their needs. For example, if the server instance slow, some network operations may fail. This could lead to issues, especially during end-to-end (E2E) operations.
Changes
SessionTimeOut data class has been added.
The default SessionTimeOut is utilized for each remote operation in the first constructor.
A second constructor has been added to allow custom SessionTimeOut injection for each remote operation.
How to Test?
Files client must build without any compile error
Files client must be able to configure SessionTimeOut for any remote operations