Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose share by mail #735

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Expose share by mail #735

wants to merge 1 commit into from

Conversation

tobiasKaminsky
Copy link
Member

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

AlvaroBrey
AlvaroBrey previously approved these changes Oct 26, 2021
@AlvaroBrey
Copy link
Member

Change looks good, but tests are failing

@tobiasKaminsky
Copy link
Member Author

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/581-IT-stable-06-59

@AlvaroBrey do you have an idea why suddenly so many tests on stable, but only on stable, fail?

@AlvaroBrey
Copy link
Member

AlvaroBrey commented Oct 27, 2021

stable-IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/581-IT-stable-06-59

@AlvaroBrey do you have an idea why suddenly so many tests on stable, but only on stable, fail?

It seems that most of the crashes are related to OCCapability. Any recent changes there?

@tobiasKaminsky
Copy link
Member Author

All solved except of lint, which complains as another dependency is outdated.

AlvaroBrey
AlvaroBrey previously approved these changes Nov 3, 2021
@tobiasKaminsky
Copy link
Member Author

/rebase

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #735 (20b435d) into master (012db19) will decrease coverage by 2.11%.
The diff coverage is 71.42%.

❗ Current head 20b435d differs from pull request most recent head c6c209c. Consider uploading reports for the commit c6c209c to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #735      +/-   ##
============================================
- Coverage     48.57%   46.47%   -2.11%     
============================================
  Files           200      164      -36     
  Lines          7697     6361    -1336     
  Branches        989      835     -154     
============================================
- Hits           3739     2956     -783     
+ Misses         3438     2965     -473     
+ Partials        520      440      -80     
Files Coverage Δ
...oud/android/lib/resources/status/OCCapability.java 59.63% <100.00%> (ø)
...sources/status/GetCapabilitiesRemoteOperation.java 48.83% <66.66%> (ø)

... and 362 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Feb 1, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@nextcloud nextcloud deleted a comment from github-actions bot Feb 1, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 1, 2024
@nextcloud nextcloud deleted a comment from github-actions bot Feb 1, 2024
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants