Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): Several print style fixes #1561

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix(css): Several print style fixes #1561

merged 1 commit into from
Nov 4, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Oct 30, 2024

  • Fixed alignment of narrow page content
  • No cropped page content on the right side
  • No page break between page title and content when printing single page
  • Print page content after first page when printing single page

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

* Fixed alignment of narrow page content
* No cropped page content on the right side
* No page break between page title and content when printing single page
* Print page content after first page when printing single page

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/print_improvements branch from 9a22fe3 to ef7859f Compare October 30, 2024 14:21
@mejo- mejo- requested a review from luka-nextcloud October 30, 2024 14:21
Copy link

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a visible before and after?

@mejo-
Copy link
Member Author

mejo- commented Oct 30, 2024

Is there a visible before and after?

Unfortunately hard to screenshot because only visible in print view. That's also why I listed exactly what this fixes.

@enjeck
Copy link

enjeck commented Oct 30, 2024

Is there a visible before and after?

Unfortunately hard to screenshot because only visible in print view. That's also why I listed exactly what this fixes.

Uh, where's the list please?

@mejo-
Copy link
Member Author

mejo- commented Oct 30, 2024

Uh, where's the list please?

Haha sorry, I only added it later to the commit message. Copied it now to the PR description above.

Copy link

@enjeck enjeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@mejo- mejo- merged commit cf26fec into main Nov 4, 2024
47 of 50 checks passed
@mejo- mejo- deleted the fix/print_improvements branch November 4, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants