Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preserve anchors in links that rendered as widget #1564

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Nov 4, 2024

📝 Summary

  1. Create long page with anchor in the bottom
  2. Create another page and insert link to first page with anchor
  3. Open preview widget

Expected result: anchor is preserved
Actual result: anchor is missing

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

src/mixins/editorMixin.js Outdated Show resolved Hide resolved
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the feature/preserve-anchors-in-links branch from ac41784 to 6b37631 Compare November 5, 2024 15:08
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this @Koc, much appreciated. I pushed a small improvement, see my comment. I hope you don't mind.

src/mixins/editorMixin.js Outdated Show resolved Hide resolved
@mejo- mejo- merged commit 8745754 into main Nov 5, 2024
51 of 52 checks passed
@mejo- mejo- deleted the feature/preserve-anchors-in-links branch November 5, 2024 15:51
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants