Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further CSS fixes #1587

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Further CSS fixes #1587

merged 2 commits into from
Nov 18, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Nov 12, 2024

📝 Summary

Tested:

  • Scrolling with long content on landing page with large desktop screen with/without search bar
  • Scrolling with short content on landing page with large desktop screen with/without search bar
  • Scrolling with long content on landing page with small mobile screen with/without search bar
  • Scrolling with short content on landing page with small mobile screen with/without search bar
fix(css): New scroll container to fix page design

* Page title always sticky at the top
* Landing page widgets (optional) and page content in scroll container
* Search bar (if visible) always sticky at bottom

Also give the editor some minimum scroll height so that it's possible to
scroll down when the landing page widgets cover full page height (e.g.
on small mobile screens) and the page has no/short content.
fix(css): Fix maximum editor/page width on mobile
Maximum width should be the smaller value of either text editor width or
screen width.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

* Page title always sticky at the top
* Landing page widgets (optional) and page content in scroll container
* Search bar (if visible) always sticky at bottom

Also give the editor some minimum scroll height so that it's possible to
scroll down when the landing page widgets cover full page height (e.g.
on small mobile screens) and the page has no/short content.

Fixes: #1578

Signed-off-by: Jonas <jonas@freesources.org>
Maximum width should be the smaller value of either text editor width or
screen width.

Fixes: #1577

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- merged commit 0ef4670 into main Nov 18, 2024
47 of 50 checks passed
@mejo- mejo- deleted the fix/editor_min_height branch November 18, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
2 participants