Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fallback to old eventdispatcher on older releases #833

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 14, 2023

Fix #828

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

@juliusknorr juliusknorr added bug Something isn't working 3. to review labels Aug 14, 2023
@cypress
Copy link

cypress bot commented Aug 14, 2023

4 failed and 1 flaky tests on run #1114 ↗︎

4 75 0 0 Flakiness 1

Details:

fix: Fallback to old eventdispatcher on older releases
Project: Collectives Commit: d8abab7709
Status: Failed Duration: 11:23 💡
Started: Sep 8, 2023 1:05 PM Ended: Sep 8, 2023 1:16 PM
Failed  pages.spec.js • 1 failed test

View Output Video

Test Artifacts
Page > Using the reference picker > Supports selecting a page from a collective Test Replay Output Screenshots
Failed  page-list.spec.js • 1 failed test

View Output Video

Test Artifacts
Page list > Page trash > allows to trash and restore page with subpage and attachment Test Replay Output Screenshots
Failed  page-details.spec.js • 1 failed test

View Output Video

Test Artifacts
Page details > Displaying backlinks > Lists backlinks for a page Test Replay Output Screenshots
Failed  apps.spec.js • 1 failed test

View Output Video

Test Artifacts
The apps > Disabled circles app does not break files view > Renders the default files list Test Replay Output Screenshots
Flakiness  cypress/e2e/pages.spec.js • 1 flaky test

View Output Video

Test Artifacts
Page > Editing a page > Lists attachments for the page and allows restore Test Replay Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@max-nextcloud
Copy link
Collaborator

would be nice to have a test for the background job on older versions so we'd see when we break it.

@juliusknorr
Copy link
Member Author

Let me just push a unit test to assert the relevant bits, a full test for the background job is more tricky

@juliusknorr juliusknorr force-pushed the bugfix/event-dispatcher-legacy branch from 4347af2 to c76543e Compare August 16, 2023 18:17
@juliusknorr
Copy link
Member Author

Pushed, though the test is not very fancy

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test! 🎉

@max-nextcloud max-nextcloud force-pushed the bugfix/event-dispatcher-legacy branch from c76543e to 7d379b6 Compare August 17, 2023 07:05
@juliusknorr juliusknorr force-pushed the bugfix/event-dispatcher-legacy branch from 7d379b6 to 19f4f4e Compare August 18, 2023 09:04
Copy link

@theroch theroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've have running this patch for several days now without any issues.

@dorpauli
Copy link

dorpauli commented Sep 1, 2023

I have also tried it. Logs are gone and so far no problems.

@max-nextcloud max-nextcloud force-pushed the bugfix/event-dispatcher-legacy branch from 19f4f4e to a85f894 Compare September 4, 2023 14:08
@level420
Copy link

level420 commented Sep 7, 2023

manually applied the PR and it works as exptected.
please release a new version of collectives compatible with nextcloud 27 (and 26) with this PR!

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/event-dispatcher-legacy branch from a85f894 to d8abab7 Compare September 8, 2023 12:58
@mejo- mejo- merged commit 1f90efc into main Sep 11, 2023
36 of 43 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix/event-dispatcher-legacy branch September 11, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IEventDispatcher issue on 27
6 participants