-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fallback to old eventdispatcher on older releases #833
Conversation
would be nice to have a test for the background job on older versions so we'd see when we break it. |
Let me just push a unit test to assert the relevant bits, a full test for the background job is more tricky |
4347af2
to
c76543e
Compare
Pushed, though the test is not very fancy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the test! 🎉
c76543e
to
7d379b6
Compare
7d379b6
to
19f4f4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've have running this patch for several days now without any issues.
I have also tried it. Logs are gone and so far no problems. |
19f4f4e
to
a85f894
Compare
manually applied the PR and it works as exptected. |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
a85f894
to
d8abab7
Compare
Fix #828
🏁 Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)