From db11d4614695a02f5b0eb6fdef30a400a96bbbea Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Thu, 5 Dec 2024 15:50:16 +0800 Subject: [PATCH] mac-crafter: Only attempt sparkle codesign if it exists in the app bundle Signed-off-by: Claudio Cambra --- .../mac-crafter/Sources/Utils/Codesign.swift | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/admin/osx/mac-crafter/Sources/Utils/Codesign.swift b/admin/osx/mac-crafter/Sources/Utils/Codesign.swift index 4b2341274c0b3..b511f0a443e27 100644 --- a/admin/osx/mac-crafter/Sources/Utils/Codesign.swift +++ b/admin/osx/mac-crafter/Sources/Utils/Codesign.swift @@ -123,14 +123,21 @@ func codesignClientAppBundle( // Multiple components of the app will now have the get-task-allow entitlements. // We need to strip these out manually. - print("Code-signing Sparkle autoupdater app (without entitlements)...") let sparkleFrameworkPath = "\(frameworksPath)/Sparkle.framework" - try recursivelyCodesign(path: "\(sparkleFrameworkPath)/Resources/Autoupdate.app", - identity: codeSignIdentity, - options: "--timestamp --force --verbose=4 --options runtime --deep") + if FileManager.default.fileExists(atPath: "\(sparkleFrameworkPath)/Resources/Autoupdate.app") { + print("Code-signing Sparkle autoupdater app (without entitlements)...") - print("Re-codesigning Sparkle library...") - try codesign(identity: codeSignIdentity, path: "\(sparkleFrameworkPath)/Sparkle") + try recursivelyCodesign( + path: "\(sparkleFrameworkPath)/Resources/Autoupdate.app", + identity: codeSignIdentity, + options: "--timestamp --force --verbose=4 --options runtime --deep" + ) + + print("Re-codesigning Sparkle library...") + try codesign(identity: codeSignIdentity, path: "\(sparkleFrameworkPath)/Sparkle") + } else { + print("Build does not have Sparkle, skipping.") + } print("Code-signing app extensions (removing get-task-allow entitlements)...") let fm = FileManager.default