Users can unlock foreign locks in groupfolders

[susnux]

See #169

But for this one it is a bug, as their is no real owner of the files.
The reason for this bug is still the same, but for groupfolders we should not assume any member a owner and allow them to unlock, but only the managers.

[Rello]

was introduced here
#140

[susnux]

As i wrote in the on the linked issue, this makes sense for user shares.
But for group folders it is weird.

[max-nextcloud]

Fixed by #171

[vincib]

Hi. I'd like to reopen this one :
we have a NC 27.1.4 using files_lock 27.0.2 and we have the following issue :

• on a groupfolder
• user A is locking a file
• user B try to lock the file
• user B get a message :

            "status": "failure",
            "statuscode": 423,
            "message": "File is currently locked by <email of user A>"

[vincib]

FYI, I have the following in the oc_files_lock table:

MariaDB@cloud1 [cloud8]> select * from oc_files_lock where file_id=1946631;
+------+----------------------------------+---------+-------------------------------------------------+------------+------+-------+-----+-------+
| id   | user_id           | file_id | token                                           | creation   | type | scope | ttl | owner |
+------+----------------------------------+---------+-------------------------------------------------+------------+------+-------+-----+-------+
| 6393 | <email of user A> | 1946631 | files_lock/d438f017-95d8-402a-83be-47952d7f8e34 | 1701179522 |    0 |     0 |   0 |       |

and we are using redis as distributed / local & lock storage.

[max-nextcloud]

user B get a message : "File is currently locked by "

Sounds like the intended behavior to me. This issue was about user B being able to unlock the file despite it being locked by user A.

My impression is that there are a lot of different expectations as to how locks should behave. What's the behavior you would expect @vincib ?

[susnux]

Sounds like the intended behavior to me.

I agree I would also expect this behavior as the file is already locked

[camlafit]

Hello

I think @vincib has miss an information, B try also to unlock the file. This user could be admin and same error occurs.
In this case behavior expected should be to unlock the file.

[camlafit]

Hello

We have continue to investigate.
This touble looks occurred when user A has only read permission. With desktop client locks looks applied anyway.
Lock is not removed and block next user B with write permission.

Thanks a lot