fix(ACL): Actually return in ACLStorageWrapper methods

Signed-off-by: provokateurin <kate@provokateurin.de>
nextcloud · Sep 10, 2024 · af88dc9 · af88dc9
1 parent 7ad4560
commit af88dc9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/lib/ACL/ACLStorageWrapper.php b/lib/ACL/ACLStorageWrapper.php
@@ -248,7 +248,7 @@ public function filemtime($path) {
 		if (!$this->checkPermissions($path, Constants::PERMISSION_READ)) {
 			return false;
 		}
-		parent::filemtime($path);
+		return parent::filemtime($path);
 	}
 
 	public function file_get_contents($path) {
@@ -269,7 +269,7 @@ public function hash($type, $path, $raw = false) {
 		if (!$this->checkPermissions($path, Constants::PERMISSION_READ)) {
 			return false;
 		}
-		parent::hash($type, $path, $raw);
+		return parent::hash($type, $path, $raw);
 	}
 
 	public function getETag($path) {

diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml
@@ -1,12 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<files psalm-version="5.16.0@2897ba636551a8cb61601cc26f6ccfbba6c36591">
+<files psalm-version="5.26.1@d747f6500b38ac4f7dfc5edbcae6e4b637d7add0">
   <file src="lib/ACL/ACLStorageWrapper.php">
-    <InvalidNullableReturnType>
-      <code>filemtime</code>
-      <code>hash</code>
-    </InvalidNullableReturnType>
     <UndefinedClass>
-      <code>IteratorDirectory</code>
+      <code><![CDATA[IteratorDirectory]]></code>
     </UndefinedClass>
   </file>
   <file src="lib/Versions/ExpireManager.php">