build: Add rector

Signed-off-by: provokateurin <kate@provokateurin.de>

composer.json

@@ -22,7 +22,8 @@
 		"psalm:update-baseline": "psalm --threads=$(nproc) --no-cache --update-baseline",
 		"psalm:fix": "psalm --no-cache --alter --issues=InvalidReturnType,InvalidNullableReturnType,MissingParamType,InvalidFalsableReturnType",
 		"test:unit": "phpunit -c tests/phpunit.xml",
-		"test:unit:coverage": "XDEBUG_MODE=coverage phpunit -c tests/phpunit.xml"
+		"test:unit:coverage": "XDEBUG_MODE=coverage phpunit -c tests/phpunit.xml",
+		"rector": "rector && composer cs:fix"
 	},
 	"config": {
 		"allow-plugins": {

lib/AppInfo/Application.php

@@ -232,7 +232,7 @@ public function boot(IBootContext $context): void {
 		$context->injectFn(function (IMountProviderCollection $mountProviderCollection, CacheListener $cacheListener, Group\Manager $groupManager): void {
 			$mountProviderCollection->registerProvider($this->getMountProvider());
 
-			$groupManager->listen('\OC\Group', 'postDelete', function (IGroup $group) {
+			$groupManager->listen('\OC\Group', 'postDelete', function (IGroup $group): void {
 				$this->getFolderManager()->deleteGroup($group->getGID());
 			});
 			$cacheListener->listen();

lib/Command/ExpireGroup/ExpireGroupVersions.php

@@ -34,16 +34,16 @@ protected function configure(): void {
 	}
 
 	protected function execute(InputInterface $input, OutputInterface $output): int {
-		$this->expireManager->listen(GroupVersionsExpireManager::class, 'enterFolder', function (array $folder) use ($output) {
+		$this->expireManager->listen(GroupVersionsExpireManager::class, 'enterFolder', function (array $folder) use ($output): void {
 			$output->writeln("<info>Expiring version in '{$folder['mount_point']}'</info>");
 		});
-		$this->expireManager->listen(GroupVersionsExpireManager::class, 'deleteVersion', function (IVersion $version) use ($output) {
+		$this->expireManager->listen(GroupVersionsExpireManager::class, 'deleteVersion', function (IVersion $version) use ($output): void {
 			$id = $version->getRevisionId();
 			$file = $version->getSourceFileName();
 			$output->writeln("<info>Expiring version $id for '$file'</info>");
 		});
 
-		$this->expireManager->listen(GroupVersionsExpireManager::class, 'deleteFile', function ($id) use ($output) {
+		$this->expireManager->listen(GroupVersionsExpireManager::class, 'deleteFile', function ($id) use ($output): void {
 			$output->writeln("<info>Cleaning up versions for no longer existing file with id $id</info>");
 		});
 

lib/Command/Scan.php

@@ -92,7 +92,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 				return -1;
 			}
 
-			$scanner->listen('\OC\Files\Cache\Scanner', 'scanFile', function ($path) use ($output, &$statsRow) {
+			$scanner->listen('\OC\Files\Cache\Scanner', 'scanFile', function ($path) use ($output, &$statsRow): void {
 				$output->writeln("\tFile\t<info>/$path</info>", OutputInterface::VERBOSITY_VERBOSE);
 				$statsRow[2]++;
 				// abortIfInterrupted doesn't exist in nc14
@@ -101,7 +101,7 @@ protected function execute(InputInterface $input, OutputInterface $output) {
 				}
 			});
 
-			$scanner->listen('\OC\Files\Cache\Scanner', 'scanFolder', function ($path) use ($output, &$statsRow) {
+			$scanner->listen('\OC\Files\Cache\Scanner', 'scanFolder', function ($path) use ($output, &$statsRow): void {
 				$output->writeln("\tFolder\t<info>/$path</info>", OutputInterface::VERBOSITY_VERBOSE);
 				$statsRow[1]++;
 				// abortIfInterrupted doesn't exist in nc14

rector.php

@@ -0,0 +1,18 @@
+<?php
+
+declare(strict_types=1);
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+use Rector\Config\RectorConfig;
+
+return RectorConfig::configure()
+	->withPaths([
+		__DIR__ . '/lib',
+		__DIR__ . '/tests',
+	])
+	->withSkip([
+		__DIR__ . '/tests/stubs',
+	])
+	->withTypeCoverageLevel(0);

vendor-bin/rector/composer.json

@@ -0,0 +1,5 @@
+{
+    "require-dev": {
+        "rector/rector": "^1.2"
+    }
+}