Error while running background job ExpireGroupVersions (with groupfolders 17.0.0). TypeError: VersionsBackend::getVersionFolderForFile(): Argument #1 ($file) must be of type OCP\Files\File, OC\Files\FileInfo given

[prolibre]

Nextcloud 29.0.0 and Nextcloud 29.0.1
The latest groupfolders update (17.0.0) introduces a new bug in the logs.

Reported by @jmechnich at #2935

{
  "reqId": "0okAL3KAiSQD23u5JJlv",
  "level": 3,
  "time": "2024-05-21T03:50:03+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "core",
  "method": "",
  "url": "--",
  "message": "Error while running background job OCA\\GroupFolders\\BackgroundJob\\ExpireGroupVersions (id: 102515, arguments: null)",
  "userAgent": "--",
  "version": "29.0.0.19",
  "exception": {
    "Exception": "TypeError",
    "Message": "OCA\\GroupFolders\\Versions\\VersionsBackend::getVersionFolderForFile(): ArgumeError while running background job OCA\\GroupFolders\\BackgroundJob\\ExpireGroupVersionsnt #1 ($file) must be of type OCP\\Files\\File, OC\\Files\\FileInfo given, called in /var/www/nextcloud/apps/groupfolders/lib/Versions/VersionsBackend.php on line 92",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/nextcloud/apps/groupfolders/lib/Versions/VersionsBackend.php",
        "line": 92,
        "function": "getVersionFolderForFile",
        "class": "OCA\\GroupFolders\\Versions\\VersionsBackend",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/apps/groupfolders/lib/Versions/GroupVersionsExpireManager.php",
        "line": 81,
        "function": "getVersionsForFile",
        "class": "OCA\\GroupFolders\\Versions\\VersionsBackend",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/apps/groupfolders/lib/Versions/GroupVersionsExpireManager.php",
        "line": 60,
        "function": "expireFolder",
        "class": "OCA\\GroupFolders\\Versions\\GroupVersionsExpireManager",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/apps/groupfolders/lib/BackgroundJob/ExpireGroupVersions.php",
        "line": 43,
        "function": "expireAll",
        "class": "OCA\\GroupFolders\\Versions\\GroupVersionsExpireManager",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/public/BackgroundJob/Job.php",
        "line": 80,
        "function": "run",
        "class": "OCA\\GroupFolders\\BackgroundJob\\ExpireGroupVersions",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php",
        "line": 102,
        "function": "start",
        "class": "OCP\\BackgroundJob\\Job",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/lib/public/BackgroundJob/TimedJob.php",
        "line": 92,
        "function": "start",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->"
      },
      {
        "file": "/var/www/nextcloud/cron.php",
        "line": 176,
        "function": "execute",
        "class": "OCP\\BackgroundJob\\TimedJob",
        "type": "->"
      }
    ],
    "File": "/var/www/nextcloud/apps/groupfolders/lib/Versions/VersionsBackend.php",
    "Line": 78,
    "message": "Error while running background job OCA\\GroupFolders\\BackgroundJob\\ExpireGroupVersions (id: 102515, arguments: null)",
    "exception": {},
    "CustomMessage": "Error while running background job OCA\\GroupFolders\\BackgroundJob\\ExpireGroupVersions (id: 102515, arguments: null)"
  }
}

Have a nice day.

[ReimuHakurei]

Needs testing, but from what I can see in the NC code, File extends Node which extends FileInfo, so this could possibly be fixed by doing the following.

In groupfolders/lib/Versions/GroupVersion.php, replace:
private File $versionFile, with private FileInfo $versionFile,

In groupfolders/lib/Versions/VersionsBackend.php, replace:
private function getFolderIdForFile(File $file): int {
with
private function getFolderIdForFile(FileInfo $file): int {

public function getVersionFolderForFile(File $file): Folder {
with
public function getVersionFolderForFile(FileInfo $file): Folder {

Someone who is actually familiar with the codebase here should verify this isn't going to horribly break anything.

[baltaner]

@ReimuHakurei
your suggested changes are stopping the errors on my server - groupfolders is still working...

[prolibre]

@ReimuHakurei your suggested changes are stopping the errors on my server - groupfolders is still working...

+1 @baltaner

[s0undy]

same issue here.

Applied changes proposed by @ReimuHakurei and it fixes the error.

Verified by manually running occ groupfolders:expire which completed without errors.

[raffaelone]

Needs testing, but from what I can see in the NC code, File extends Node which extends FileInfo, so this could possibly be fixed by doing the following.

In groupfolders/lib/Versions/GroupVersion.php, replace: private File $versionFile, with private FileInfo $versionFile,

In groupfolders/lib/Versions/VersionsBackend.php, replace: private function getFolderIdForFile(File $file): int { with private function getFolderIdForFile(FileInfo $file): int {

public function getVersionFolderForFile(File $file): Folder { with public function getVersionFolderForFile(FileInfo $file): Folder {

Someone who is actually familiar with the codebase here should verify this isn't going to horribly break anything.

Appling this fix I take another error from logs

TypeError
OCA\GroupFolders\Versions\GroupVersion::getVersionFile(): Return value must be of type OCP\Files\File, OC\Files\FileInfo returned
Error while running background job OCA\GroupFolders\BackgroundJob\ExpireGroupVersions (id: 31591, arguments: null)

[klatka]

Needs testing, but from what I can see in the NC code, File extends Node which extends FileInfo, so this could possibly be fixed by doing the following.

In groupfolders/lib/Versions/GroupVersion.php, replace: private File $versionFile, with private FileInfo $versionFile,

In groupfolders/lib/Versions/VersionsBackend.php, replace: private function getFolderIdForFile(File $file): int { with private function getFolderIdForFile(FileInfo $file): int {

public function getVersionFolderForFile(File $file): Folder { with public function getVersionFolderForFile(FileInfo $file): Folder {

Someone who is actually familiar with the codebase here should verify this isn't going to horribly break anything.

One was missing:

In groupfolders/lib/Versions/GroupVersion.php, replace: public function getVersionFile(): File { with public function getVersionFile(): FileInfo {

[raffaelone]

One was missing:

In groupfolders/lib/Versions/GroupVersion.php, replace: public function getVersionFile(): File { with public function getVersionFile(): FileInfo {

Error disappeared and the app works correctly. Manually running occ groupfolders:expire is completed without errors.
Thanks

[ordilibre]

Same context expect on Ubuntu 22.04.4 LTS (GNU/Linux 5.15.0-107-generic x86_64); same error encountered.

Applied changes proposed by @ReimuHakurei and it fixes the error.
Verified by manually running occ groupfolders:expire which completed without errors.

Thank you

[solracsf]

Hi @artonge as you've worked on this, can you take a look when possible? Thanks 👍

[s0undy]

Applied #2989 in my production environment and looks like it fixes the issue. Unsure how to completely veriy, i ran occ groupfolders:expire manually without errors. No errors from background jobs either.