Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shallow scanning of specific paths #2232

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

steffenclemens
Copy link
Contributor

@steffenclemens steffenclemens commented Jan 14, 2023

Adding feature requested in #1168.
Close #1168

@solracsf
Copy link
Member

Thanks. Can you fix DCO?

@zak39
Copy link
Contributor

zak39 commented May 5, 2023

Hi @steffenclemens 🙂

To fix the DCO, you can follow these steps 👉 https://github.com/nextcloud/groupfolders/pull/2232/checks?check_run_id=10651495499

@steffenclemens steffenclemens force-pushed the feature/shallow-scanning branch from 1c2b3a8 to 7af6b96 Compare May 12, 2023 22:05
@steffenclemens
Copy link
Contributor Author

steffenclemens commented May 12, 2023

Hi @steffenclemens 🙂

To fix the DCO, you can follow these steps 👉 https://github.com/nextcloud/groupfolders/pull/2232/checks?check_run_id=10651495499

Hi @solracsf and @zak39, thanks for the hint.

@steffenclemens
Copy link
Contributor Author

Hi @solracsf, @zak39. Is anything left for me to do here?

@solracsf
Copy link
Member

No, wait for reviews and merge. ⏳

@steffenclemens
Copy link
Contributor Author

No, wait for reviews and merge. ⏳

Alright, thanks! 🙂

@solracsf solracsf added the 3. to review Items that need to be reviewed label Jul 26, 2023
@solracsf solracsf added the feature: occ Items related to the OCC CLI interface label Jul 27, 2023
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good otherwise

lib/Command/Scan.php Outdated Show resolved Hide resolved
@Ornanovitch
Copy link

Sorry to bump this but is there any hope to see this implemented soon? This would be a really great improvement..

@steffenclemens
Copy link
Contributor Author

Sorry to bump this but is there any hope to see this implemented soon? This would be a really great improvement..

Thanks for the reminder! I added the required commit.

@steffenclemens steffenclemens force-pushed the feature/shallow-scanning branch from 708365b to 3d586c5 Compare May 19, 2024 12:44
@Ornanovitch
Copy link

Thanks :)

Will it work with scanning a specific file, like occ files:scan --path?

@steffenclemens
Copy link
Contributor Author

Thanks :)

Will it work with scanning a specific file, like occ files:scan --path?

You can scan files of a specific directory without stepping down in the tree using: occ groupfolders:scan <folderid> -p /path/to/your/directory --shallow.
So this will only scan files that are directly in /path/to/your/directory.
Use occ groupfolders:list to find the folder id.

@steffenclemens
Copy link
Contributor Author

@Ornanovitch occ groupfolders:scan -h shows you all options with description.

@steffenclemens steffenclemens force-pushed the feature/shallow-scanning branch from f89b73b to e32bfd1 Compare May 20, 2024 11:16
@Ornanovitch

This comment was marked as resolved.

@Ornanovitch

This comment was marked as resolved.

@Ornanovitch
Copy link

Note that it works with a single file 🥳

@Ornanovitch
Copy link

@icewind1991 any chance to merge this awesome feature?

@skjnldsv skjnldsv requested review from yemkareems and come-nc and removed request for CarlSchwan August 28, 2024 12:17
Signed-off-by: Steffen Clemens <info@steffenclemens.de>
steffenclemens and others added 2 commits August 28, 2024 14:18
Signed-off-by: Steffen Clemens <info@steffenclemens.de>
Signed-off-by: Steffen Clemens <info@steffenclemens.de>
@skjnldsv skjnldsv force-pushed the feature/shallow-scanning branch from e32bfd1 to 0424c8d Compare August 28, 2024 12:18
@skjnldsv
Copy link
Member

skjnldsv commented Aug 28, 2024

@Ornanovitch & @steffenclemens : I rebased and pinged more devs for this :)
cc @icewind1991, please address your review again 🙇

@skjnldsv skjnldsv merged commit 8d02101 into nextcloud:master Aug 28, 2024
39 of 41 checks passed
@skjnldsv skjnldsv added 4. to release Items that are ready for releasing and removed 3. to review Items that need to be reviewed labels Aug 28, 2024
@nextcloud nextcloud deleted a comment from Ornanovitch Sep 16, 2024
@nextcloud nextcloud deleted a comment from Ornanovitch Sep 16, 2024
@provokateurin
Copy link
Member

Sorry, we don't backport features.

@Ornanovitch
Copy link

I understand but does it mean this feature won't be able before NC 31? That would be unexpected, because it was ready before the milestone even exist.. :/

@provokateurin
Copy link
Member

It will be available for NC 31, but not 30 or any other existing version.

@provokateurin
Copy link
Member

It was just merged too later after the branch off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Items that are ready for releasing feature: occ Items related to the OCC CLI interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

occ groupfolders:scan : scan only a specific folder like occ files:scan --path
8 participants