Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix all property, param and return types #3245

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

provokateurin
Copy link
Member

Uses strong types whenever possible, otherwise doc types (or when they add more information). Any other types are removed to inherit from the parents.

@provokateurin provokateurin added 3. to review Items that need to be reviewed technical debt labels Sep 17, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Sep 17, 2024
@provokateurin provokateurin force-pushed the fix/psalm/param-property-return-types branch from 9c201e5 to 5af3b03 Compare September 17, 2024 16:31
@provokateurin
Copy link
Member Author

(I also checked with #3234, everything passes fine)

@provokateurin provokateurin force-pushed the fix/psalm/param-property-return-types branch 2 times, most recently from ce21956 to 8100774 Compare September 17, 2024 17:35
lib/ACL/Rule.php Outdated Show resolved Hide resolved
lib/ACL/Rule.php Outdated Show resolved Hide resolved
lib/Command/ACL.php Outdated Show resolved Hide resolved
lib/Command/Group.php Outdated Show resolved Hide resolved
@provokateurin provokateurin force-pushed the fix/psalm/param-property-return-types branch from 8100774 to 30aa462 Compare September 18, 2024 17:13
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the fix/psalm/param-property-return-types branch from 30aa462 to a21dac1 Compare September 18, 2024 17:50
@come-nc come-nc merged commit 83acbe3 into master Sep 19, 2024
48 checks passed
@come-nc come-nc deleted the fix/psalm/param-property-return-types branch September 19, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants