Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neon_talk): Support adding and removing reactions #2063

Merged
merged 3 commits into from
May 22, 2024

Conversation

provokateurin
Copy link
Member

Closes #2037
The added patch is the equivalent of nextcloud/spreed#12386
I know adding the reactions button to every message is a bit ugly, but I will fix that properly with #2038 when a proper menu is introduced.

@provokateurin provokateurin requested a review from Leptopoda May 22, 2024 05:35
Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 80.43478% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 29.84%. Comparing base (766e775) to head (d48d8e4).
Report is 3 commits behind head on main.

Current head d48d8e4 differs from pull request most recent head 2a2eeee

Please upload reports for the commit 2a2eeee to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
+ Coverage   29.49%   29.84%   +0.34%     
==========================================
  Files         254      254              
  Lines       84690    84774      +84     
==========================================
+ Hits        24983    25302     +319     
+ Misses      59707    59472     -235     
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from ec9c6aa
dynamite 31.00% <ø> (ø) Carriedforward from ec9c6aa
dynamite_end_to_end_test 61.47% <ø> (ø) Carriedforward from ec9c6aa
dynamite_runtime 85.40% <ø> (ø) Carriedforward from ec9c6aa
neon_dashboard 92.56% <ø> (ø)
neon_framework 39.94% <ø> (ø)
neon_talk 96.77% <100.00%> (+0.29%) ⬆️
nextcloud 26.48% <30.76%> (+0.35%) ⬆️
sort_box 90.90% <ø> (ø) Carriedforward from ec9c6aa

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
packages/neon/neon_talk/lib/src/blocs/room.dart 97.67% <100.00%> (+1.08%) ⬆️
...ckages/neon/neon_talk/lib/src/widgets/message.dart 100.00% <100.00%> (ø)
...ages/neon/neon_talk/lib/src/widgets/reactions.dart 100.00% <100.00%> (ø)
packages/nextcloud/lib/src/api/spreed.openapi.dart 29.24% <ø> (+1.14%) ⬆️
...ckages/nextcloud/lib/src/api/spreed.openapi.g.dart 13.24% <30.76%> (+0.76%) ⬆️

@provokateurin
Copy link
Member Author

provokateurin commented May 22, 2024

Ah I forgot to add tests for the bloc part (but everything else can be reviewed already).

@provokateurin provokateurin marked this pull request as draft May 22, 2024 05:58
@provokateurin provokateurin force-pushed the feat/neon_talk/add-reactions branch from 2ae1fff to d48d8e4 Compare May 22, 2024 07:26
@provokateurin provokateurin marked this pull request as ready for review May 22, 2024 07:26
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin force-pushed the feat/neon_talk/add-reactions branch from d48d8e4 to 2a2eeee Compare May 22, 2024 13:21
@provokateurin provokateurin enabled auto-merge May 22, 2024 13:25
@provokateurin provokateurin merged commit b7e550d into main May 22, 2024
8 checks passed
@provokateurin provokateurin deleted the feat/neon_talk/add-reactions branch May 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow adding emoji reactions to messages
2 participants