Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TB 68 support #80

Closed
johndoe7000 opened this issue Aug 30, 2019 · 64 comments · May be fixed by #85
Closed

Add TB 68 support #80

johndoe7000 opened this issue Aug 30, 2019 · 64 comments · May be fixed by #85

Comments

@johndoe7000
Copy link

Hello,

please add Thunderbird 68.0 support.
There are also some nice pull requests in the pipe... "Add random password generation support for each upload" would be really nice.

@e-alfred
Copy link

e-alfred commented Sep 9, 2019

@oparoz @guillaumev It would be great to revive this extension. Do you know which parts have to be fixed to make it work with Thunderbird 68?

@adhome1
Copy link

adhome1 commented Sep 9, 2019

Yes please try a update. There are near none FileLink alternatives for 68.0
Perhaps this can help:
https://developer.thunderbird.net/add-ons/updates
At least a manifest.json is needed. Also other 68.0 FileLink addons can help to be analysed.

@guillaume-smo
Copy link

The WebDav filelink provider module works well with TB68 and NextCloud if it can help.

@e-alfred
Copy link

@guillaume-smo How did you set up the Webdav filelink provider?

@uku69
Copy link

uku69 commented Sep 24, 2019

@gulliaume-smo:
Yes, the upload to nextcloud is working fine with WebDAV.
But: the link created couldn't be used at mail receivers.
First a password is needed and second it's not possible to download the document :-O
If I upload a document manually to nextcloud and generate a link and add the link to the mail, the system works fine :-)

@thenamelessthing
Copy link

I agree with this request!

guillaumev added a commit that referenced this issue Oct 14, 2019
@guillaumev
Copy link
Collaborator

I created a PR here: #82 This is in a very early stage and for now, nothing works, but help will be greatly appreciated :-)

@ediazcomellas
Copy link

Will it help if I post a bounty for this?

@e-alfred
Copy link

e-alfred commented Nov 5, 2019

@ediazcomellas I think posting a bounty is always a good incentive.

@ediazcomellas
Copy link

$100 added.

@e-alfred
Copy link

@jospoortvliet Can you add this repository to the Bountysource bot?

@jospoortvliet
Copy link
Member

@e-alfred done. Sorry, I rarely manage to catch up to notifications in github :(

@serafin84
Copy link

Hello,
Can anyone tell me how to run this add-on or sending nextcloud attachments in the latest thunderbird?

@mxa
Copy link

mxa commented Dec 11, 2019

Maybe someone can link the bountysource page here, I could not find it.

@tobiasKaminsky
Copy link
Member

@josepmendoza
Copy link

Onwcloud addon:
https://addons.thunderbird.net/es/thunderbird/addon/filelink-provider-for-owncloud/

Github repo:
https://github.com/thosmos/filelink-owncloud

Doesn't work with Nextcloud, but I've made a fork with a little patch that works with Nextcloud:
https://github.com/josepmendoza/filelink-owncloud

@sebastienserre
Copy link

Doesn't work with Nextcloud, but I've made a fork with a little patch that works with Nextcloud:
https://github.com/josepmendoza/filelink-owncloud
Could you please add a readme.md explaining how to install it without an .xpi please ?

@josepmendoza
Copy link

Installation

  1. Zip all files located in the root folder such that the manifest.json in the root folder of the zip file
  2. Name this zip file as filelink-owncloud@thosmos.com.xpi
  3. Open your Thunderbird, and install as addon file.

or download my packed and patched addon: filelink-owncloud-patched

@sebastienserre
Copy link

Unfortunately, I have an error message "Imposible to upload to Owncloud" :-(

@manu-p
Copy link

manu-p commented Dec 31, 2019

Hi, thanks @josepmendoza

Works fine on my side with TB68.2.2 and NC16.0.7.
And on NC17.0.2 too.

I'm using an app token as proposed and just had to replace the storage path to the previous /Mail-attachments/ value.

@sebastienserre
Copy link

forgot to replace /Mailattachments/ on my settings to /Mail-attachments/
and it works! Thx @manu-p & @josepmendoza

@e-alfred
Copy link

e-alfred commented Jan 3, 2020

@oparoz @guillaumev Can you merge the fixed code and release an official app?

@merrx
Copy link

merrx commented Jan 7, 2020

Onwcloud addon:
https://addons.thunderbird.net/es/thunderbird/addon/filelink-provider-for-owncloud/

Github repo:
https://github.com/thosmos/filelink-owncloud

Doesn't work with Nextcloud, but I've made a fork with a little patch that works with Nextcloud:
https://github.com/josepmendoza/filelink-owncloud

The owncloud version from @thosmos didn't work with my universities owncloud, but the nextcloud version from @josepmendoza works fine. The owncloud version can upload the file, but it didn't paste anything in my mail (forever spinning indicator).

May I suggest adding some random numbers (?) to the file name as the old version did. So it doesn't make filename collisions if uploading the same file twice.

@thosmos
Copy link

thosmos commented Jan 24, 2020

Onwcloud addon:
https://addons.thunderbird.net/es/thunderbird/addon/filelink-provider-for-owncloud/
Github repo:
https://github.com/thosmos/filelink-owncloud
Doesn't work with Nextcloud, but I've made a fork with a little patch that works with Nextcloud:
https://github.com/josepmendoza/filelink-owncloud

The owncloud version from @thosmos didn't work with my universities owncloud, but the nextcloud version from @josepmendoza works fine. The owncloud version can upload the file, but it didn't paste anything in my mail (forever spinning indicator).

May I suggest adding some random numbers (?) to the file name as the old version did. So it doesn't make filename collisions if uploading the same file twice.

I've incorporated @josepmendoza's changes and also the random file name into the published version 1.7 at https://addons.thunderbird.net/es/thunderbird/addon/filelink-provider-for-owncloud/

I have it working on both owncloud and nextcloud. I would appreciate feature requests or bugs be made at its repo https://github.com/thosmos/filelink-owncloud

@wagnbeu0
Copy link

Perfect, can you share a version with the nextcloud Logos as well?

@e-alfred
Copy link

@thosmos Awesome work, but maybe @jospoortvliet @guillaumev @oparoz can add you as a collaborator to this repository? It would be good to have this in the main repository so people can simply update their extension instead of removing the "official" one and installing another one.

@jurgenhaas
Copy link

I second that, the *cloud plugin is awesome.

@ChristophWurst
Copy link
Member

Sure, go ahead. I only gave a suggestion for those who don't know where to put the money. It's still your money, so your choice 😉

@qm2k
Copy link

qm2k commented Jun 24, 2020

Oh, and if you really like *cloud, I'd also be very grateful for some stars on gitlab or reviews in Thunderbird's Addon Repository .

Just wrote a review on Thunderbird's Addon Repository -- the extension is great, actually better then the official defunct addon was.

Would you please share the direct link on gitlab repository you'd like to have the stars on? EDIT: Oops, the link was in the previous message.

@joendres
Copy link

Sure, go ahead. I only gave a suggestion for those who don't know where to put the money. It's still your money, so your choice 😉

Bountysource tells me, that I can claim it as soon as #80 is closed as fixed. @ChristophWurst can you do that?

@joendres
Copy link

@qm2k thanks a lot. The project ist here: https://gitlab.com/joendres/filelink-nextcloud

@ChristophWurst
Copy link
Member

Please ask someone of the contributors to close this ticket as I do not want to get into other people's stuff.

@e-alfred
Copy link

It would be awesome to make *cloud the new official Thunderbird plugin for Nextcloud. Right now all links go to this deprecated repository leading people to a non-working extension.

@ChristophWurst
Copy link
Member

I'm super new to this repo. I didn't even know there was a Thunderbird plugin for Nextcloud. So excuse my basic questions but is the other one a fork of this one? What is stopping you from updating the references to the new repo (on gitlab)?

@ChristophWurst
Copy link
Member

@guillaumev @michaelletzgus @NDev8 @uli-heller would any of you have a problem with us closing this ticket so @joendres can claim the bounty?

Let's proceed with closing unless one of these four contributors raises objections. Two weeks is a reasonable time frame, I guess.

@joendres
Copy link

@ChristophWurst

I'm super new to this repo. I didn't even know there was a Thunderbird plugin for Nextcloud. So excuse my basic questions but is the other one a fork of this one? What is stopping you from updating the references to the new repo (on gitlab)?

No, I started from scratchbecause the current API has nothing in common with the legacy one.

@uli-heller
Copy link
Contributor

uli-heller commented Jun 24, 2020 via email

@ediazcomellas
Copy link

Looks like a good solution to me.

@joendres
Copy link

joendres commented Jul 20, 2020

@ChristophWurst it's been 3 weeks now. I'd be grateful if you could close the bug.

TIA, @joendres

@uli-heller
Copy link
Contributor

I'm fine with closing but I cannot close it personally

@joendres
Copy link

Sorry, I mentined the wrong person. @oparoz is the one to inform.

@ChristophWurst it's been 3 weeks now. I'd be grateful if you could close the bug.

@joendres
Copy link

joendres commented Aug 8, 2020

OK, I give up. None of the Contributor seems to be willing to close this issue. I had a brief contact with @oparoz via twitter, but he is unresponsive there too. I'd like to discuss how to close this in a way that a) makes users happy b) makes bountysource happy. But nobody answers. So this issue will be open forever, the links from nextcloud.com will point to the disfunctional Addon, Nextcloud users might find *cloud (or not), and bountysource will put the bounty in its own pocket in the end. Whatever... 🤷‍♂️

@ediazcomellas
Copy link

How can I help?

@joendres
Copy link

joendres commented Aug 8, 2020

I don't know, I'm just frustrated. By now I've literally spent hours to get somebody to communicate with me, who can decide and act on this project. That's more time than the bounty is worth -- just unsuccessfully trying to establish communication. Don't get me wrong: There are some people at Netxcloud, who try to be helpful. But they tell me, they can't decide. And those, they point me to, just don't communicate. So I'll stop reaching out and I'll try to forget about the whole thing.

@uku69
Copy link

uku69 commented Aug 9, 2020

I am also fine with the *cloud extension. it's working without any problems. Does nobody know how to reach @oparoz for closing down this issue and force to pay out the bounties?
on the other hand - the request was opened by @johndoe7000... ?

@uli-heller
Copy link
Contributor

OK, I give up. None of the Contributor seems to be willing to close this issue. ...

The fact that you have to ask again and again is really bad. I don't know who can close the issue. But for sure, you cannot close it just because you're a contributor. Beside my name, this project says "Contributor" - probably because I proposed a pull request before - but I cannot close any issue. There is no "close issue" button. Sorry.

@ediazcomellas
Copy link

I've asked for a refund of the bounty and will send it directly to @joendres once I get it back.

@ChristophWurst
Copy link
Member

I don't know, I'm just frustrated. By now I've literally spent hours to get somebody to communicate with me, who can decide and act on this project. That's more time than the bounty is worth -- just unsuccessfully trying to establish communication. Don't get me wrong: There are some people at Netxcloud, who try to be helpful. But they tell me, they can't decide. And those, they point me to, just don't communicate. So I'll stop reaching out and I'll try to forget about the whole thing.

I'm sorry for the frustration caused. It's holiday season and some of us are simply offline for their days off, and so have I. Thus there was no communication from us.

What's left? Just closing of the ticket?

@e-alfred
Copy link

What's left? Just closing of the ticket?

@ChristophWurst Well, all of this:

the links from nextcloud.com will point to the disfunctional Addon, Nextcloud users might find *cloud (or not)

*cloud is the right addon, the "official" seems to be deprecated.

@ChristophWurst
Copy link
Member

If you give me a link we can try to find the source at https://github.com/nextcloud/nextcloud.com to change that link to the "new" addon

@ediazcomellas
Copy link

Unfortunately I retired my pledge at bountysource yesterday! I will send the bounty directly to Johannes.

@e-alfred
Copy link

@ChristophWurst
Copy link
Member

Done nextcloud/nextcloud.com#1336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet