Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared folders are not paginated #540

Closed
ValdasK opened this issue Nov 12, 2020 · 2 comments
Closed

Shared folders are not paginated #540

ValdasK opened this issue Nov 12, 2020 · 2 comments
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working needs info Not enough information provided performances Performances issues and optimisations

Comments

@ValdasK
Copy link

ValdasK commented Nov 12, 2020

Describe the bug
Trying to understand how things work (for other feature request) I'v noticed that when you open shared folder, its contents are not paginated (everything opens at once) like when you open non-shared one (thumbs are loaded in chunks), which leads to poor performance and occasionally stalls browser tab.

To Reproduce
Steps to reproduce the behavior:

  1. Go to shared folder with plenty of photos (in my case, 4 000)
  2. Click on folder containing those photos
  3. Notice that thousands of requests for thumbnails are made to server, and browser freezes for a while

Expected behavior
First N photos should be loaded, all others should wait until scroll down like in other categories.

(using NC 19.0.4)

@ValdasK ValdasK added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Nov 12, 2020
@skjnldsv
Copy link
Member

This should be fixed with nc21 :)
It's mostly because the virtual grid (not rendering the full list and faking the scrollable page height) was only enabled on the timeline view.

We changed and improved a lot for 21. I'll let thi sone opened until you're able to try the release in a few months 😉

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Nov 12, 2020
@skjnldsv skjnldsv added this to the Nextcloud 21 milestone Nov 12, 2020
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Nov 12, 2020
@rullzer rullzer removed this from the Nextcloud 21 milestone Mar 1, 2021
@joshtrichards
Copy link
Member

@ValdasK Okay to close this old issue out? :)

@joshtrichards joshtrichards added needs info Not enough information provided performances Performances issues and optimisations labels Oct 7, 2023
@ValdasK ValdasK closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working needs info Not enough information provided performances Performances issues and optimisations
Projects
None yet
Development

No branches or pull requests

4 participants