Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc optimizations #3741

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Misc optimizations #3741

merged 7 commits into from
Oct 7, 2024

Conversation

dartcafe
Copy link
Collaborator

@dartcafe dartcafe commented Oct 7, 2024 •
edited
Loading

  • fix for showing hidden participants
  • updates dependencies
  • consequently use user.id instead of userId
  • Same for displayName etc.
  • move current share to sessionStore
  • individual imports from nextcloud/vue (shrinks bundle size by 50 %)
  • sorting imports
    • vue imports
    • external modules
      • imports from Nexcloud libs
    • Icons imports (material-design)
    • polls modules imports

@dartcafe
repplace shareStore by sessionStore.share
69dfe49 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
seperate ShareType from UserType and use user props from user
1e23227 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
use user.id instead of userId
7d25684 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
deps update
bab0d07 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
switch to individual imports for @nextcloud/vue
3e5705d 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
sorting imports
26f578d 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe
fix safeTable
57e128b 
Signed-off-by: dartcafe <github@dartcafe.de>
@dartcafe dartcafe added bug dependencies Pull requests that update a dependency file refactor labels Oct 7, 2024
@dartcafe dartcafe added this to the 8.0 milestone Oct 7, 2024
@dartcafe dartcafe merged commit 552cd76 into next Oct 7, 2024
17 checks passed
@dartcafe dartcafe mentioned this pull request Oct 8, 2024
Merged
@dartcafe dartcafe deleted the refactor/misc/next branch October 10, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug dependencies Pull requests that update a dependency file refactor
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
1 participant
@dartcafe