Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign guest name input #3368

Closed
juliusknorr opened this issue Dec 19, 2023 · 3 comments · Fixed by #3606
Closed

Redesign guest name input #3368

juliusknorr opened this issue Dec 19, 2023 · 3 comments · Fixed by #3606
Assignees
Labels
1. to develop Waiting for a developer design Related to the design enhancement New feature or request

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Dec 19, 2023

As brought up by @jancborchardt

  • reference for asking guest name from Talk: Add a welcome window to set username for guests spreed#10467
  • We need to show the input before loading the document as we need to pass the name along to Collabora
  • We can take the opportunity to get rid of quite some legacy code there then and do it properly with new vue components
@juliusknorr juliusknorr added enhancement New feature or request 1. to develop Waiting for a developer design Related to the design labels Dec 19, 2023
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Dec 19, 2023
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Dec 19, 2023
@jancborchardt
Copy link
Member

FYI @szaimen assigned you for the design part since you did the same for Talk, but since it’s already done for Talk I don’t think much more is needed, right @juliushaertl? Just so it is known who can answer follow-up questions.

@juliusknorr
Copy link
Member Author

Just to confirm, clarify on how I would imagine the adapted talk mockup to public file shares, however if a quick mockup can be provided that is probably the best:

  • Opening a single public share link shows the public share link page in the background and opens the modal directly to enter the name, once confirmed the name the document will open
  • On a shared folder we will show the modal once the user opens a file, once confirmed the name the document will open
  • The modal would show:
    • "Enter your name to join the "My document.odt" as a guest."
    • Input to enter the name, prefilled with a placeholder "Anonymous guest"
    • Button to "Submit name and join"
    • Talk shows the call icon and name, should we show something similar as the header of the modal?

@juliusknorr juliusknorr self-assigned this Dec 21, 2023
@juliusknorr juliusknorr removed their assignment Mar 3, 2024
@juliusknorr
Copy link
Member Author

@elzody Since you are checking the other ticket about the guest name picker, this might be valuable input to consider when recreating the picker in vue

@elzody elzody moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Apr 4, 2024
@elzody elzody moved this from 📄 To do (~10 entries) to 🧭 Planning evaluation (don't pick) in 📝 Office team Apr 4, 2024
@elzody elzody self-assigned this Apr 4, 2024
@elzody elzody moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Apr 4, 2024
@elzody elzody moved this from 📄 To do (~10 entries) to 🧭 Planning evaluation (don't pick) in 📝 Office team Apr 4, 2024
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Apr 5, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Apr 30, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Waiting for a developer design Related to the design enhancement New feature or request
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants