From 9dcf8dad8d6c3f047148fffedefc1abb8b184094 Mon Sep 17 00:00:00 2001 From: fenn-cs Date: Wed, 6 Dec 2023 22:05:57 +0100 Subject: [PATCH] Remove `newPassword` from share model, if disabled It's important to delete the `newPassword` prop from the share model, if the user unchecks the isPasswordProtected checkbox. This clearer and allows for the unchecking to actually work as `this.$set()` fails with the falsy value `''`. Signed-off-by: fenn-cs --- apps/files_sharing/src/views/SharingDetailsTab.vue | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/apps/files_sharing/src/views/SharingDetailsTab.vue b/apps/files_sharing/src/views/SharingDetailsTab.vue index a4a312fcc0e3d..d882aac9b87c0 100644 --- a/apps/files_sharing/src/views/SharingDetailsTab.vue +++ b/apps/files_sharing/src/views/SharingDetailsTab.vue @@ -417,9 +417,13 @@ export default { || !!this.share.password }, async set(enabled) { - // TODO: directly save after generation to make sure the share is always protected - this.share.password = enabled ? await GeneratePassword() : '' - this.$set(this.share, 'newPassword', this.share.password) + if (enabled) { + this.share.password = await GeneratePassword() + this.$set(this.share, 'newPassword', this.share.password) + } else { + this.share.password = '' + this.$delete(this.share, 'newPassword') + } }, }, /**