Skip to content

Commit

Permalink
fix(external_storage): Cast id to int
Browse files Browse the repository at this point in the history
  • Loading branch information
oleksandr-nc authored and backportbot[bot] committed Dec 3, 2024
1 parent fbfe307 commit e25bb2f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions apps/files_external/lib/Service/StoragesService.php
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ protected function readConfig() {
* @return StorageConfig
* @throws NotFoundException if the storage with the given id was not found
*/
public function getStorage($id) {
public function getStorage(int $id) {
$mount = $this->dbConfig->getMountById($id);

if (!is_array($mount)) {
Expand Down Expand Up @@ -476,7 +476,7 @@ public function updateStorage(StorageConfig $updatedStorage) {
*
* @throws NotFoundException if no storage was found with the given id
*/
public function removeStorage($id) {
public function removeStorage(int $id) {

Check notice

Code scanning / Psalm

MissingReturnType Note

Method OCA\Files_External\Service\StoragesService::removeStorage does not have a return type, expecting void
$existingMount = $this->dbConfig->getMountById($id);

if (!is_array($existingMount)) {
Expand Down

0 comments on commit e25bb2f

Please sign in to comment.