Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Create new" Icon is not in line with sidebar #40550

Closed
pschopen opened this issue Sep 21, 2023 · 12 comments
Closed

"Create new" Icon is not in line with sidebar #40550

pschopen opened this issue Sep 21, 2023 · 12 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug design Design, UI, UX, etc. feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@pschopen
Copy link

As my previous issue got closed and this is actually a different problem and rather something for the design team to do, I decided to create a new issue for this.

Before having the redesigned "new" button I didn't realise that margin doesn't match the sidebar, now it's obvious:

align properly

Originally posted by @pschopen in #40510 (comment)

@solracsf solracsf added design Design, UI, UX, etc. good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 21, 2023
@SAGARSINGH-1
Copy link

Hey @pschopen ,

Can you please explain a bit more where it is causing an error so that we can discover and fix it?

@pschopen
Copy link
Author

It's not an error in the first place. It's just not ideally designed so something for the design team to be decided. I guess the best option would be to apply the same margin to sidebar and main container. Then everything would be aligned properly.

Maybe @nimishavijay can have a look?

@SAGARSINGH-1
Copy link

Yeah I'll set it's margin and padding can you give me more details where it button appears.

@nimishavijay
Copy link
Member

Yes, makes sense! The navigation toggle, breadcrumbs component and the new item button should all the middle aligned :)

@SAGARSINGH-1
Copy link

Thanks I'll try to fix it.

@pschopen
Copy link
Author

Apparently that is especially obvious in the files app, but also other apps have this issue.

Deck:
grafik

Calendar:
grafik

Contacts:
grafik

Mail doesn't:
grafik

@SAGARSINGH-1
Copy link

Where i can find local setup readme or somthing.

@ASP124
Copy link

ASP124 commented Oct 18, 2023

Hello, Is this issue still open to be resolved or can it be assigned to me?

@nimishavijay
Copy link
Member

@ASP124 it is still open, you can work on it if you would like! Resources on contributing code can be found at nextcloud.com/developer :)

@5gorsky
Copy link

5gorsky commented Oct 21, 2023

Hello! I'd like to get involved and help as a designer but I'm very new to this. Could you please tell me how exactly can I do it? Where do I find initial designs to correct/change them in Figma?

@nimishavijay
Copy link
Member

@5gorsky you can find more about contributing to design at https://nextcloud.com/design/ :)

@susnux
Copy link
Contributor

susnux commented Mar 4, 2024

Fixed for 28

@susnux susnux closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback bug design Design, UI, UX, etc. feature: files good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

8 participants