Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Set expiration date" can be disabled but it doesn't look disabled #41171

Closed
5 of 8 tasks
thgoebel opened this issue Oct 28, 2023 · 1 comment · Fixed by #40928
Closed
5 of 8 tasks

[Bug]: "Set expiration date" can be disabled but it doesn't look disabled #41171

thgoebel opened this issue Oct 28, 2023 · 1 comment · Fixed by #40928
Assignees

Comments

@thgoebel
Copy link

thgoebel commented Oct 28, 2023

⚠️ This issue respects the following points: ⚠️

Bug description

The "Set expiration date" checkbox cannot be visually unchecked if a non-enforced default expiration date is configured by the admin.

This seems to have been introduced in #40629 in an attempt to fix #40612.

Steps to reproduce

  1. Admin: Enable "Set default expiration date for shares" and set a data but do NOT enable "Enforce expiration date" (under /settings/admin/sharing)
  2. User: create a new share. Notice how since Updates to new sharing flow #40629 the default expiration date is correctly set
  3. Click "Set expiration date" in an attempt to un-check it

Actual behaviour

The "Set expiration date" box remains checked. The date values are reset, and under the hood the expiration date is correctly unset. Just the UI is wrong.

Expected behavior

The checkbox should become unchecked.

Installation method

Community Docker image

Nextcloud Server version

27.1.3

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

n/a, see https://github.com/nextcloud/server/issues/40612

List of activated Apps

n/a, see https://github.com/nextcloud/server/issues/40612

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

n/a

Additional info

Screenshot

@thgoebel thgoebel added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Oct 28, 2023
@szaimen
Copy link
Contributor

szaimen commented Oct 28, 2023

Cc @fenn-cs

@nfebe nfebe removed the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Oct 28, 2023
@nfebe nfebe self-assigned this Oct 28, 2023
@nfebe nfebe moved this to ☑️ Done in 📁 Files team Oct 28, 2023
@nfebe nfebe closed this as completed Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants