Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we fire UserChangedEvent when setUserValue method is used? #41938

Open
akhil1508 opened this issue Nov 30, 2023 · 4 comments
Open

Can we fire UserChangedEvent when setUserValue method is used? #41938

akhil1508 opened this issue Nov 30, 2023 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: users and groups php Pull requests that update Php code

Comments

@akhil1508
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.

  • I have some apps in nextcloud that set user values using setUserValue
  • I would like to develop a new app that can check when certain such values are updated and develop some functionality on top of this

Describe the solution you'd like

Describe alternatives you've considered

  • Patch the server code to fire this event

Additional context

  • My understanding from checking the code and by logging locally is that this event is not fired. Please close this issue if it is indeed fired and there is something going wrong in my setup.
@akhil1508 akhil1508 added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Nov 30, 2023
@nickvergessen
Copy link
Member

I wouldn't fire the same event, but I also can see it would be useful to be able to "subscribe" to those changes sometimes.

@nickvergessen nickvergessen added 1. to develop Accepted and waiting to be taken care of feature: users and groups php Pull requests that update Php code and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 30, 2023
@akhil1508
Copy link
Contributor Author

I wouldn't fire the same event, but I also can see it would be useful to be able to "subscribe" to those changes sometimes.

How does UserConfigChangedEvent sound? @nickvergessen

@nickvergessen
Copy link
Member

either that or UserPreferenceChangedEvent

Could also go with …Set… because adding is not changing, but well doesn't matter as long as it's properly documented.

@akhil1508 akhil1508 mentioned this issue Dec 5, 2023
Open
@joshtrichards joshtrichards changed the title [Development feature request] Can we fire UserChangedEvent when setUserValue method is used? Can we fire UserChangedEvent when setUserValue method is used? Sep 14, 2024
@akhil1508
Copy link
Contributor Author

akhil1508 commented Sep 16, 2024 •
edited
Loading

either that or UserPreferenceChangedEvent

@nickvergessen Implemented UserConfigChangedEvent in a PR #42039 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: users and groups php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nickvergessen @akhil1508