Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all features within the contacts menu button on the header to unified search #42386

Closed
marcoambrosini opened this issue Dec 20, 2023 · 9 comments

Comments

@marcoambrosini
Copy link
Member

This feature has been duplicated since the global search has been there. Now that the global search is even better, we should remove it.

Screenshot from 2023-12-20 09-24-44

@marcoambrosini marcoambrosini added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap design Design, UI, UX, etc. labels Dec 20, 2023
@emoral435 emoral435 self-assigned this Dec 21, 2023
@marcoambrosini
Copy link
Member Author

ping @nextcloud/designers

@nimishavijay
Copy link
Member

It was recently reworked to include more useful information, but I agree that we should check if this is needed, especially because there are already 4 other icons in the right side of the top bar, cc @jancborchardt

@emoral435
Copy link
Contributor

If it looks like it can be removed, I can start to work on removing it with nextcloud/designers approval (don't want to ping again ;) ) with the requirements that you guys would propose!

@marcoambrosini
Copy link
Member Author

It was recently reworked to include more useful information

We can move this to the search results in the unified search.

@emoral435
Copy link
Contributor

We should then rename the issue, something like eg: "move all features of the contacts menu to unified search" or something along those lines.

It seemingly just needs to have these additions added:

image
more information | relative local time

@emoral435 emoral435 changed the title Remove contacts menu Move all features within the contacts menu button on the header to unified search Jan 2, 2024
@joshtrichards
Copy link
Member

Does #22329 still apply? If so, it may be a factor.

@emoral435
Copy link
Contributor

That is true. As that issue has not had much traffic for the last three years, I assume its priority is not that high up. However, if its a small change, it can be added within the implementation that I am drafting up!

@emoral435 emoral435 added 2. developing Work in progress and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 5, 2024
@emoral435 emoral435 removed their assignment Jan 11, 2024
@emoral435
Copy link
Contributor

I'll unassign myself on this issue from now, as I have to work on accessibility issues, but after chatting with Marco, I misunderstood what was needed to be done, we should move the results of the search to be on the main search functionality! Not the filters, whoops!

Around here:
image

@jancborchardt
Copy link
Member

Just FYI @marcoambrosini @emoral435 issue #22329 was fixed in 28 via #40559

Moving this to the search does not work, as people should have this info at a glance and not need to search first. So the contacts menu is something we want to improve rather than remove.

Opened a new design spec about this at #43763

@jancborchardt jancborchardt closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants