Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: NC 28 - uploading files via drag&drop into the browser broken #42587

Closed
5 of 8 tasks
arnowelzel opened this issue Jan 4, 2024 · 12 comments
Closed
5 of 8 tasks

Comments

@arnowelzel
Copy link
Contributor

⚠️ This issue respects the following points: ⚠️

Bug description

Before NC 28 it was possible to upload a file by dragging it into the file list. Now this not possible any longer. When dragging a file into the view, a box at the top appears which says "Drag and drop files here to upload" but it will close and open all the time and you can not drop the file.

Steps to reproduce

  1. Open the files app
  2. Drag a file from a local drive into the browser
  3. See the error

Expected behavior

The box "Drag and drop files here to upload" will appear when dragging a file into the view and will stay visible, so you can actually drop the file to upload.

Installation method

Community Manual installation with Archive

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.3

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

Screen-Capture which shows the problem:

nextcloud28-upload-error.mp4
@arnowelzel arnowelzel added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 4, 2024
@arnowelzel arnowelzel changed the title [Bug]: NC 28 - uploading files via drag&drop into the browser broken [Bug]: NC 28 - uploading files via drag&drop is browser broken Jan 4, 2024
@arnowelzel arnowelzel changed the title [Bug]: NC 28 - uploading files via drag&drop is browser broken [Bug]: NC 28 - uploading files via drag&drop into the browser broken Jan 4, 2024
@GeneralTab
Copy link

experiencing the same problem please do let me know if there is any temp fixes.

@solracsf
Copy link
Member

solracsf commented Jan 4, 2024

Maybe fixed by #42366 ?

@pjrobertson
Copy link
Contributor

pjrobertson commented Jan 5, 2024

Maybe fixed by #42366 ?

Quite likely fixed by this yes.

How can I build a production copy of the files app to drop in a replacement? I was hoping to just use that PR .patch file but the js needs compiling.

I tried following https://docs.nextcloud.com/server/latest/developer_manual/server/code-front-end.html#building-vue-components-and-scripts but the dist folder produced didn't have any usable files app.

EDIT: - I realised the dist files are all checked in to that PR, so tried copying them over to my production install (files-main.js*) but unfortunately that doesn't work

EDIT #2 copying the files from stable28 did work:

cd /var/www/nextcloud/dist
sudo wget https://raw.githubusercontent.com/nextcloud/server/4f3eb7c37e83ae6b09d206106fd13a2459a42da9/dist/files-main.js.map
... and the same for the other 3 files

@baltaner
Copy link

baltaner commented Jan 6, 2024

@pjrobertson
Hi, thank you for your investigation - it seems to work for my installation.
But one question: what do you mean with "... and the same for the other 3 files"?
in the dist-folder are exactly 3 files. I only copy files-main.js and files-main.js.map
Or did I make a mistake?

@pjrobertson
Copy link
Contributor

The third file I was referring to is the LICENSE file which doesn't technically need copying over

@arnowelzel
Copy link
Contributor Author

THERE IS BUG in file app in nextcloud.... after web install from stable to beta.... all files that has to be showed WILL DISSAPEARE on recycle there show and on photo they show too.: here is file BUG:

Sorry to hear about your problems - but this has nothing to do with this issue here: file upload using drag & drop in the browser.

Also keep in mind that a BETA version is not stable and it can be that there are bugs - that's why it is called "BETA". So of course it is NOT a bug, if there are problems in the BETA version.

Also see here: https://nextcloud.com/de/blog/nextcloud-release-channels-and-how-to-track-them/ - quote: "Beta ... These are suitable to check if bugs are fixed but can break any time."

And about "nextcloud BAD explained": the Nextcloud documentation about the required modules in https://docs.nextcloud.com/server/latest/admin_manual/installation/php_configuration.html is very clear. Of course you have to know how to install PHP modules in your Linux distribution.

@sugartarou
Copy link

Maybe fixed by #42366 ?

Quite likely fixed by this yes.

How can I build a production copy of the files app to drop in a replacement? I was hoping to just use that PR .patch file but the js needs compiling.

I tried following https://docs.nextcloud.com/server/latest/developer_manual/server/code-front-end.html#building-vue-components-and-scripts but the dist folder produced didn't have any usable files app.

EDIT: - I realised the dist files are all checked in to that PR, so tried copying them over to my production install (files-main.js*) but unfortunately that doesn't work

EDIT #2 copying the files from stable28 did work:

cd /var/www/nextcloud/dist
sudo wget https://raw.githubusercontent.com/nextcloud/server/4f3eb7c37e83ae6b09d206106fd13a2459a42da9/dist/files-main.js.map
... and the same for the other 3 files

I tried this, and successed.
I got and applied only 2 files (dist/files-main.js and dist/files-main.jp.map).
Thank you.

@corincorvus
Copy link

Hey, can i replace the file-main files with the 27.1.x version without errors for usable drag and drop?
Or get i other errors, if i do that?

Thanks

@arnowelzel
Copy link
Contributor Author

Hey, can i replace the file-main files with the 27.1.x version without errors for usable drag and drop?
Or get i other errors, if i do that?

No, this will not work. NC 28 is a major change to NC 27 - many apps needed to get updated to support NC 28 because of that.

In general: do not replace single files in a production installation with stuff you picked from a Github repository. You can not really know, if that will work or not and you also risk get security problems with untested code.

@skjnldsv
Copy link
Member

Duplicate of #42136

@skjnldsv skjnldsv marked this as a duplicate of #42136 Jan 11, 2024
@skjnldsv skjnldsv closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
@skjnldsv skjnldsv removed the 0. Needs triage Pending check for reproducibility or if it fits our roadmap label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

11 participants