You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am by no means a PHP expert, please tell me if I am mistaken.
To me, the way the code is constructed would indicate that CNAME is always queried, even when A succeeded. This aligns with what I am observing in my DNS server logs:
@solracsf any progress or update on this? I usually cannot afford to keep issues open for a long time; otherwise I lose the overview. The fix for this should also take not more than 5 minutes, for me maybe 20 considering I do not know PHP.
Bug description
I am looking at this code:
server/lib/private/Http/Client/DnsPinMiddleware.php
Lines 61 to 89 in 4281ce6
Important
I am by no means a PHP expert, please tell me if I am mistaken.
To me, the way the code is constructed would indicate that CNAME is always queried, even when A succeeded. This aligns with what I am observing in my DNS server logs:
Wouldn't it make more sense to skip CNAME when
canHaveCnameRecord
isfalse
, and we should setcanHaveCnameRecord
outside the loop?Steps to reproduce
Expected behavior
When
canHaveCnameRecord
isfalse
, we should not query for CNAME.Nextcloud Server version
29
Operating system
Debian/Ubuntu
PHP engine version
PHP 8.3
Web server
Apache (supported)
Database engine version
PostgreSQL
Is this bug present after an update or on a fresh install?
None
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
Configuration report
List of activated Apps
Nextcloud Signing status
Nextcloud Logs
Additional info
This is not a showstopper in any way; I just think the behavior is neither expected nor desirable.
The text was updated successfully, but these errors were encountered: