Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Downloading multiple Files from recent Files in webgui results in empty Zip #48708

Open
5 of 8 tasks
eHeinrich-wsa opened this issue Oct 15, 2024 · 8 comments · Fixed by #49203
Open
5 of 8 tasks

Comments

@eHeinrich-wsa
Copy link

eHeinrich-wsa commented Oct 15, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

When downloading multiple Files from recent files an empty zip file gets downloaded. When downloading the same files from the actual folder it works as expected. Possibly because the download url does not include the directory for the files.
When downloading from recent files:
/apps/files/ajax/download.php?dir=/&files= etc.
When downloading from actual folder:
/apps/files/ajax/download.php?dir=/Foldername&files= etc.

Steps to reproduce

  1. Go to recent Files
  2. Select multiple Files
  3. Click Download
  4. Receive empty Zip File

Expected behavior

Download Zip Folder with selected Files

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.1

Web server

Apache (supported)

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "pgsql",
        "version": "28.0.11.1",
        "overwriteprotocol": "https",
        "htaccess.RewriteBase": "\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauthtype": "PLAIN",
        "mail_smtpauth": 1,
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpsecure": "tls",
        "default_phone_region": "DE",
        "default_locale": "de_DE",
        "default_language": "de",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0
        },
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "debuglevel": 0,
        "updater.release.channel": "stable",
        "theme": "",
        "loglevel": 1,
        "log_rotate_size": 20971520,
        "maintenance": false,
        "maintenance_window_start": 1,
        "enabledPreviewProviders": {
            "0": "OC\\Preview\\Movie",
            "1": "OC\\Preview\\PNG",
            "2": "OC\\Preview\\JPEG",
            "3": "OC\\Preview\\GIF",
            "4": "OC\\Preview\\BMP",
            "5": "OC\\Preview\\XBitmap",
            "6": "OC\\Preview\\MP3",
            "7": "OC\\Preview\\MP4",
            "8": "OC\\Preview\\TXT",
            "9": "OC\\Preview\\MarkDown",
            "10": "OC\\Preview\\HEIC",
            "11": "OC\\Preview\\Font",
            "12": "OC\\Preview\\Illustrator",
            "14": "OC\\Preview\\MSOffice2003",
            "15": "OC\\Preview\\MSOffice2007",
            "16": "OC\\Preview\\MSOfficeDoc",
            "17": "OC\\Preview\\PDF",
            "18": "OC\\Preview\\Photoshop",
            "19": "OC\\Preview\\Postscript",
            "20": "OC\\Preview\\StarOffice",
            "21": "OC\\Preview\\SVG",
            "22": "OC\\Preview\\TIFF",
            "23": "OC\\Preview\\EMF",
            "24": "OC\\Preview\\OpenDocument"
        },
        "preview_libreoffice_path": "\/usr\/bin\/libreoffice",
        "preview_ffmpeg_path": "\/usr\/bin\/ffmpeg",
        "preview_max_x": 4096,
        "preview_max_y": 4096,
        "app.mail.imap.timeout": 240
    }
}

List of activated Apps

Enabled:
  - activity: 2.20.0
  - breezedark: 28.0.1
  - bruteforcesettings: 2.8.0
  - calendar: 4.7.16
  - cloud_federation_api: 1.11.0
  - comments: 1.18.0
  - contacts: 5.5.3
  - contactsinteraction: 1.9.0
  - dav: 1.29.2
  - federatedfilesharing: 1.18.0
  - files: 2.0.0
  - files_automatedtagging: 1.18.0
  - files_pdfviewer: 2.9.0
  - files_reminders: 1.1.0
  - files_retention: 1.17.2
  - files_sharing: 1.20.0
  - files_trashbin: 1.18.0
  - files_versions: 1.21.0
  - forms: 4.3.1
  - groupfolders: 16.0.10
  - guests: 3.0.1
  - impersonate: 1.15.0
  - logreader: 2.13.0
  - lookup_server_connector: 1.16.0
  - mail: 3.7.8
  - nextcloud_announcements: 1.17.0
  - notifications: 2.16.0
  - oauth2: 1.16.4
  - password_policy: 1.18.0
  - photos: 2.4.0
  - polls: 7.2.4
  - previewgenerator: 5.6.0
  - privacy: 1.12.0
  - provisioning_api: 1.18.0
  - recommendations: 2.0.0
  - related_resources: 1.3.0
  - richdocuments: 8.3.11
  - richdocumentscode: 24.4.702
  - serverinfo: 1.18.0
  - settings: 1.10.1
  - sharebymail: 1.18.0
  - support: 1.11.1
  - survey_client: 1.16.0
  - systemtags: 1.18.0
  - text: 3.9.2
  - theming: 2.3.0
  - twofactor_backupcodes: 1.17.0
  - unroundedcorners: 1.1.3
  - updatenotification: 1.18.0
  - viewer: 2.2.0
  - workflowengine: 2.10.0
Disabled:
  - admin_audit: 1.18.0 (installed 1.17.0)
  - circles: 28.0.0 (installed 24.0.0)
  - dashboard: 7.8.0 (installed 7.4.0)
  - encryption: 2.16.0
  - event_update_notification: 2.4.0 (installed 2.4.0)
  - federation: 1.18.0 (installed 1.14.0)
  - files_external: 1.20.0 (installed 1.16.1)
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - firstrunwizard: 2.17.0 (installed 2.13.0)
  - suspicious_login: 6.0.0
  - twofactor_totp: 10.0.0-beta.2
  - user_ldap: 1.19.0
  - user_status: 1.8.1 (installed 1.4.0)
  - weather_status: 1.8.0 (installed 1.4.0)

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@eHeinrich-wsa eHeinrich-wsa added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Oct 15, 2024
@Kieltux
Copy link

Kieltux commented Oct 19, 2024

I can confirm this bug with Nextcloud 29.0.8.
Download more than one selected file from "Recent Files" results in an empty .zip file.
The download.zip is everytime just 98 bytes and without content.

@Hoeze
Copy link

Hoeze commented Nov 1, 2024

Same issue here. Nextcloud Hub 9 (30.0.1), from official docker image.

@skjnldsv
Copy link
Member

skjnldsv commented Nov 8, 2024

cc @susnux didn't we address that already a few weeks ago?

@joshtrichards
Copy link
Member

Fixed in #48098

@Kieltux
Copy link

Kieltux commented Nov 10, 2024

Just updated to Nextcloud 29.0.9 (Release 07.11.2024) and the result is still an empty zip.
Is this only fixed in future versions? Maybe only in Nextcloud 31, which is not released so far?
Thank you.

@joshtrichards
Copy link
Member

Since this was resolved as part of a new feature addition, it's only in the upcoming v31 code base.

@susnux
Copy link
Contributor

susnux commented Nov 10, 2024

For 30 and before we should fix this if there is time for it and until 31 is released.

@susnux susnux reopened this Nov 10, 2024
@susnux susnux added 3. to review Waiting for reviews 30-feedback and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 11, 2024
@skjnldsv
Copy link
Member

Was it working before?
Or did we just add the feature unknowingly because of the new file action?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants