Implement TextToImage OCP API #40326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
come-nc
reviewed
Oct 12, 2023
juliusknorr
reviewed
Oct 12, 2023
marcelklehr
force-pushed
the
enh/text-to-image-api
branch
from
7f96cc0 to
3e7fd5e
Compare
marcelklehr
force-pushed
the
enh/text-to-image-api
branch
from
67ad446 to
19e8d07
Compare
| $providers = [$provider]; | ||
| } | ||
| } catch (\JsonException $e) { | ||
| $this->logger->warning('Failed to decode Text2Image setting `ai.text2image_provider`', ['exception' => $e]); |
There was a problem hiding this comment.
return? Or can we proceed without valid settings?
There was a problem hiding this comment.
It will use the first registered provider if the setting is not set or can't be read. We can change it to error out if the setting isn't valid, but I don't see a good reason.
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Julius Härtl <jus@bitgrid.net> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
…ast_updated to DATETIME Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
come-nc
reviewed
Oct 23, 2023
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
…imeException Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
come-nc
reviewed
Oct 26, 2023
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
come-nc
reviewed
Oct 26, 2023
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
come-nc
reviewed
Oct 26, 2023
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
come-nc
reviewed
Oct 26, 2023
come-nc
approved these changes
Oct 26, 2023
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
|
/compile |
AndyScherzinger
approved these changes
Oct 26, 2023
|
🎉 |
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
|
Failures seem unrelated, please merge 🙏 |
ChristophWurst
added
the
pending documentation
|
the new public API needs docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements an OCP API for registering and consuming text to image providers like stable diffusion.
Todo
Checklist