Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): Account property scope actions #40938

Merged
merged 4 commits into from
Oct 24, 2023
Merged

fix(settings): Account property scope actions #40938

merged 4 commits into from
Oct 24, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Oct 16, 2023 •
edited
Loading

Summary

Before After
image image

Checklist

@Pytal Pytal added the 2. developing Work in progress label Oct 16, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Oct 16, 2023
@Pytal Pytal self-assigned this Oct 16, 2023
@Pytal Pytal mentioned this pull request Oct 14, 2023
Closed
4 tasks
Pytal added 4 commits October 23, 2023 15:53
@Pytal
fix(settings): Remove aria-label on scope actions
18a2391 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(settings): Name for scope button
a9fdc52 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(settings): Styles for scope button
f0bb5e7 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
5a562a5 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/a11y/change-scope-actions branch from 79966f6 to 5a562a5 Compare October 23, 2023 23:10
@Pytal Pytal added 3. to review Waiting for reviews bug feature: settings accessibility and removed 2. developing Work in progress labels Oct 23, 2023
@Pytal Pytal marked this pull request as ready for review October 23, 2023 23:15
@Pytal Pytal merged commit 450985f into master Oct 24, 2023
42 checks passed
@Pytal Pytal deleted the fix/a11y/change-scope-actions branch October 24, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfebe nfebe nfebe approved these changes

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@ShGKme ShGKme Awaiting requested review from ShGKme

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility bug feature: settings
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
2 participants
@Pytal @nfebe