Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theming: Allow to reset custom app order and keep focus when reordering #41024

Merged
merged 3 commits into from
Oct 22, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 20, 2023

Summary

  • Allow to restore / reset the app order
  • Keep the focus on the pressed button when reordering (important for keyboard usage)
    • If the button is no longer visible (because it can not be moved higher) then move focus to the other button.

Screen recording

vokoscreenNG-2023-10-21_01-06-33.mp4

Checklist

When pressing a button for changing the app order that button should keep the focus after reordering the list.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…lt value

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/follow-up-app-order branch from 533503e to 18cb827 Compare October 21, 2023 01:52
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 22, 2023
@skjnldsv skjnldsv merged commit 4b70f19 into master Oct 22, 2023
40 checks passed
@skjnldsv skjnldsv deleted the fix/follow-up-app-order branch October 22, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: theming ❄️ 2023-Winter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants