fix(settings): users page html validation #41034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove non-existing `button-class` from `NcAppNavigationNew` - Type: use `input-id` instead of `id` on `NcSelect` to be labeled - Encode uniqueId with user's ID, because user.id may contain space Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Labeling with `<label>` doesn't work in some screen readers. `<label>` also doesn't work as a clickable link here. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
added
bug
3. to review
susnux
approved these changes
Oct 21, 2023
JuliaKirschenheuter
approved these changes
Oct 23, 2023
|
Cypress fail is related |
Or not... Works fine locally |
Not related, the tests are quite flaky. Pushed a fix here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
button-classnot allowed on elementdivat this point.button-classfromNcAppNavigationNewforattribute of thelabelelement must be the ID of a non-hidden form control.input-idinstead ofidonNcSelectto be labeledquota-progressAdmin 25x1kcgi6srsfor attributeforon elementlabel: An ID must not contain whitespace.Error: Bad value
quota-progressAdmin 25x1kcgi6srsfor attributeidon elementprogress: An ID must not contain whitespace.uniqueIdwith user's ID, becauseuser.idmay contain spaceAlso change
<label>for<progress>in user quota witharia-labelledby, because<label>doesn't work here in some screen readers (NDVA) and there is no need in an actual clickable<label>link.No visual changes.
Checklist