fix(provisioning_api): Fix quota fields in OpenAPI #41045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
marcelklehr,
julien-nc,
bigcat88 and
andrey18106
andrey18106
approved these changes
Oct 22, 2023
provokateurin
force-pushed
the
fix/openapi/provisioning_api/quota-fields
branch
from
58c9266 to
80169d5
Compare
Signed-off-by: jld3103 <jld3103yt@gmail.com>
provokateurin
force-pushed
the
fix/openapi/provisioning_api/quota-fields
branch
from
80169d5 to
d019392
Compare
nickvergessen
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should have been fixed in #40426.
All this storage code is very old and psalm doesn't understand most of it, so it doesn't show any errors. I manually verified that this is the correct way to type those fields.
Checklist