Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dav): implement personal absence settings backend #41051

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 23, 2023

Summary

The backend for #40616.

All (related) feedback from #40767 is addressed here.

Checklist

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

apps/dav/lib/Db/AbsenceMapper.php Outdated Show resolved Hide resolved
apps/dav/lib/Db/Absence.php Dismissed Show dismissed Hide dismissed
apps/dav/lib/Service/AbsenceService.php Dismissed Show dismissed Hide dismissed
@solracsf solracsf added this to the Nextcloud 28 milestone Oct 27, 2023
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the feat/dav/absence-db branch from d4cbd23 to 45ed9b1 Compare October 28, 2023 22:09
@ChristophWurst ChristophWurst merged commit d0db4d6 into master Oct 30, 2023
48 of 50 checks passed
@ChristophWurst ChristophWurst deleted the feat/dav/absence-db branch October 30, 2023 11:27
@@ -5,7 +5,7 @@
<name>WebDAV</name>
<summary>WebDAV endpoint</summary>
<description>WebDAV endpoint</description>
<version>1.28.0</version>
<version>1.29.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: 1.28.1 would have been nice instead, to keep in sync with the NC version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semantic > syntactic versioning 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants