Return correct status if touch failed #41062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading a file to an external s3 bucket, the original mtime is not kept. It boils down to the touch operation being deactivated for existing file for s3 buckets. Limitation introduced here: #21734
This PR changes the return value of the
touch
method. Now this method returnsfalse
when the file already exists to trigger the following condition:server/lib/private/Files/View.php
Lines 560 to 571 in e66e8ba