Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dashboard): html validation #41063

Merged
merged 2 commits into from
Oct 23, 2023
Merged

fix(dashboard): html validation #41063

merged 2 commits into from
Oct 23, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 23, 2023

Summary

Error: Element div not allowed as child of element h2 in this context. (Suppressing further errors from this subtree.)

Error: Element div not allowed as child of element label in this context. (Suppressing further errors from this subtree.)

TODO

  • Replace div icon with span icon

No Visual Changes.

image

image

Checklist

ShGKme added 2 commits October 23, 2023 16:20
@ShGKme
fix(dashboard): use span instead of div for icon to html
3b017ec 
- div is not valid in h2
- div is not valid in label

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(assets): Recompile assets
4ac06a8 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added this to the Nextcloud 28 milestone Oct 23, 2023
@ShGKme ShGKme self-assigned this Oct 23, 2023
@ShGKme ShGKme mentioned this pull request Oct 23, 2023
Draft
7 tasks
susnux
susnux approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

I wonder if we should add a HTML validation CI step to prevent this in the first place.

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 23, 2023

Makes sense 👍

I wonder if we should add a HTML validation CI step to prevent this in the first place.

We should (there is an issue somewhere from Andy), but after the end of the main accessibility project

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 23, 2023

Drone fail is unrelated, but I cannot merge if CI is red

@szaimen
Copy link
Contributor

szaimen commented Oct 23, 2023

Drone failure urelated

@szaimen szaimen merged commit 8bd1294 into master Oct 23, 2023
40 checks passed
@szaimen szaimen deleted the fix/37092/dashboard-html-validation branch October 23, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility bug feature: dashboard
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @szaimen @susnux