Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] fix(sharing): set name to target name in sharing cache #41073

Merged
merged 2 commits into from
Dec 14, 2023
Merged

[stable25] fix(sharing): set name to target name in sharing cache #41073

merged 2 commits into from
Dec 14, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #40495

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.13 milestone Oct 23, 2023
@solracsf
Copy link
Member

This needs #39944 ?

@miaulalala
Copy link
Contributor

This needs #39944 ?

same PR, just a backport. But seems there's some changes missing.

@skjnldsv skjnldsv mentioned this pull request Oct 25, 2023
Merged
4 tasks
@skjnldsv skjnldsv closed this Oct 27, 2023
@skjnldsv
Copy link
Member

25 is now EOL

@juliusknorr juliusknorr reopened this Nov 8, 2023
@juliusknorr juliusknorr force-pushed the backport/40495/stable25 branch from 920eb27 to 6ddd019 Compare November 8, 2023 13:58
@juliusknorr
Copy link
Member

Adapted to also work without #41073 for now as long as it is not merged

max-nextcloud and others added 2 commits November 8, 2023 15:23
@max-nextcloud @juliusknorr
fix(sharing): set name to target name in sharing cache
c0c8809 
Fixes #39879.

Signed-off-by: Max <max@nextcloud.com>
@juliusknorr
test(files_sharing): Test if recent files result use actual share tar…
6ea20ec 
…get name

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the backport/40495/stable25 branch from 6ddd019 to 6ea20ec Compare November 8, 2023 14:23
@blizzz blizzz removed this from the Nextcloud 25.0.13 milestone Nov 10, 2023
@blizzz blizzz added the 3. to review Waiting for reviews label Nov 22, 2023
@miaulalala miaulalala removed their request for review November 29, 2023 16:11
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 14, 2023
@blizzz blizzz merged commit fcca971 into stable25 Dec 14, 2023
29 of 30 checks passed
@blizzz blizzz deleted the backport/40495/stable25 branch December 14, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@blizzz blizzz blizzz approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@solracsf @miaulalala @skjnldsv @juliusknorr @blizzz @max-nextcloud