Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Align contents of profile picture heading #48572

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Oct 4, 2024

Summary

Fix #48411

Before After
image image

Checklist

@Pytal Pytal added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: settings labels Oct 4, 2024
@Pytal Pytal requested review from sorbaugh and a team October 4, 2024 23:37
@Pytal Pytal self-assigned this Oct 4, 2024
@Pytal Pytal requested review from nfebe and szaimen and removed request for a team October 4, 2024 23:37
@Pytal
Copy link
Member Author

Pytal commented Oct 4, 2024

/compile

@Pytal
Copy link
Member Author

Pytal commented Oct 4, 2024

/backport to stable30

@Aminzarbani

This comment was marked as off-topic.

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux
Copy link
Contributor

susnux commented Oct 23, 2024

@Pytal conflicts 😔

@Aminzarbani

This comment was marked as spam.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@skjnldsv skjnldsv force-pushed the fix/align-avatar-visibility branch from 899bd1c to 556519d Compare October 29, 2024 10:48
@skjnldsv
Copy link
Member

Rebased

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 29, 2024
@skjnldsv skjnldsv disabled auto-merge October 29, 2024 13:27
@skjnldsv skjnldsv merged commit 9aec7b9 into master Oct 29, 2024
117 of 118 checks passed
@skjnldsv skjnldsv deleted the fix/align-avatar-visibility branch October 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile settings: Profile image visiblity button not aligned
5 participants