Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(systemtags): add bulk tagging action #48786

Merged
merged 12 commits into from
Oct 29, 2024
Merged

feat(systemtags): add bulk tagging action #48786

merged 12 commits into from
Oct 29, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 18, 2024 •
edited
Loading

Fix #45935

image

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Oct 18, 2024
@skjnldsv skjnldsv self-assigned this Oct 18, 2024
@skjnldsv skjnldsv force-pushed the feat/files-bulk-tagging branch 3 times, most recently from dc9cbf5 to 14b2817 Compare October 23, 2024 07:27
@skjnldsv skjnldsv force-pushed the feat/files-bulk-tagging branch 3 times, most recently from 02602f0 to f69c5be Compare October 26, 2024 07:06
@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv force-pushed the feat/files-bulk-tagging branch 3 times, most recently from 9a86741 to 1e8dddc Compare October 26, 2024 13:45
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 29, 2024
@skjnldsv skjnldsv marked this pull request as ready for review October 29, 2024 08:08
skjnldsv added 10 commits October 29, 2024 09:08
@skjnldsv
feat(systemtags): add bulk tagging action
405a267 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
feat(core): add index to systemtag objecttype
0893d4b 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
feat(dav): add systemtag object IDs listing
f24b93e 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
feat(systemtags): add etag support and handle proppatch
14e2a8d 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
feat(systemtags): emit tags changes and optimise tag updates performa…
2cc3771 
…nces

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
feat(systemtags): create tag from bulk tagging dialog
db546e1 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
feat(systemtags): add cypress tests and fix a few logic issues
d51cf45 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(systemtags): single-node bulk tagging action
a4d7518 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(systemtags): translations and etag method casing
f536c86 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
chore: compile assets
1940b4f 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(systemtags): no bulk action on public pages
569f235 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
fix(files_sharing): fix view only actions button selector
3e6d18a 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feat/files-bulk-tagging branch from 1e8dddc to 3e6d18a Compare October 29, 2024 08:11
@skjnldsv skjnldsv requested review from susnux, provokateurin, a team, szaimen, sorbaugh and nfebe and removed request for a team October 29, 2024 10:13
@szaimen szaimen removed their request for review October 29, 2024 10:15
@skjnldsv skjnldsv enabled auto-merge October 29, 2024 10:17
provokateurin
provokateurin approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PHP looks good to me, just a minor suggestion

core/Migrations/Version31000Date20241018063111.php
$table = $schema->getTable('systemtag');

if (!$table->hasColumn('etag')) {
$table->addColumn('etag', 'string', [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$table->addColumn('etag', 'string', [
$table->addColumn('etag', Types::STRING, [

@skjnldsv skjnldsv merged commit 73fdf2c into master Oct 29, 2024
179 checks passed
@skjnldsv skjnldsv deleted the feat/files-bulk-tagging branch October 29, 2024 10:20
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 29, 2024
This was referenced Oct 29, 2024
Merged
Merged
@nickvergessen nickvergessen mentioned this pull request Dec 4, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@susnux susnux susnux approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

@nfebe nfebe Awaiting requested review from nfebe

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: dav feature: files
Projects
📁 Files team
Status: 🏗️ In progress
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

Add Bulk Tagging on new Files app [28+]
3 participants
@skjnldsv @susnux @provokateurin