Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an error log message that notifications app isn't enabled at file… #49232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

falghamdi125
Copy link
Contributor

@falghamdi125 falghamdi125 commented Nov 12, 2024

Summary

This PR adds an error log message telling admin that the notifications app is not enabled at the files_reminders app loading.

Checklist

Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@falghamdi125 falghamdi125 force-pushed the files_reminders-logging-notifications-app-not-enabled branch from e403b7a to 5ebe213 Compare November 13, 2024 04:51
@solracsf solracsf added this to the Nextcloud 31 milestone Nov 17, 2024
@joshtrichards
Copy link
Member

@falghamdi125 Can you fix your commit message? We use Conventional Commit style messages here these days.

@joshtrichards
Copy link
Member

/backport to stable30

@joshtrichards
Copy link
Member

/backport to stable29

@joshtrichards
Copy link
Member

/backport to stable28

@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 24, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

… isn't enabled at files_reminders app load.

Signed-off-by: Faisal Alghamdi <falghamdi125@gmail.com>
@falghamdi125 falghamdi125 force-pushed the files_reminders-logging-notifications-app-not-enabled branch from 5ebe213 to 3d410aa Compare November 29, 2024 15:31
@falghamdi125
Copy link
Contributor Author

@falghamdi125 Can you fix your commit message? We use Conventional Commit style messages here these days.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Files_reminders app doesn't load, and no error is shown if the notification app is not installed.
4 participants