-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(systemtags): add color support #49295
Conversation
887004b
to
d7df8e8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
51a2dff
to
99a7346
Compare
a0248a7
to
6bf50f7
Compare
6bf50f7
to
c6afe55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very very nice! I have no feedback. @marcoambrosini?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@jancborchardt There is also the inline tag display missing on this PR. I'll keep them like they are right now, no background and color the text+border only, following the WCAG contrast of course. Quick example (careful, contrast hasn't been calculated, this is just a mockup) |
1f51a54
to
c6bd30d
Compare
c6bd30d
to
cd13290
Compare
cd13290
to
c745389
Compare
c745389
to
d802ead
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
d802ead
to
99a4f5a
Compare
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
99a4f5a
to
885b692
Compare
Thanks a lot for this. What is the planend release Version? |
@disaster123 Nextcloud 31 Hub 10 |
fix #6778
WIP
In progress
Screenshot