Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(systemtags): add color support #49295

Merged
merged 7 commits into from
Dec 6, 2024
Merged

feat(systemtags): add color support #49295

merged 7 commits into from
Dec 6, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 14, 2024

fix #6778
WIP

In progress

  • Add color backend support
  • Add bulk tagging UI color support
  • Add inline tags color support

Screenshot

image

@skjnldsv skjnldsv added enhancement design Design, UI, UX, etc. 2. developing Work in progress feature: tags labels Nov 14, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 14, 2024
@skjnldsv skjnldsv self-assigned this Nov 14, 2024
@skjnldsv

This comment was marked as resolved.

@skjnldsv skjnldsv force-pushed the feat/systemtags-bulk-create-list branch from 51a2dff to 99a7346 Compare November 15, 2024 10:10
@skjnldsv skjnldsv force-pushed the feat/tags-colors branch 4 times, most recently from a0248a7 to 6bf50f7 Compare November 15, 2024 10:13
Base automatically changed from feat/systemtags-bulk-create-list to master November 15, 2024 11:03
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very very nice! I have no feedback. @marcoambrosini?

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry actually I do have 2 pieces of feedback :D

  • The popover seems to be very slightly misaligned to the left:
    Screenshot From 2024-11-20 14-10-17
  • There is a stray triangle here:
    image

@marcoambrosini

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 21, 2024

@jancborchardt There is also the inline tag display missing on this PR.
But I read many of your comments on the topic from here and here

I'll keep them like they are right now, no background and color the text+border only, following the WCAG contrast of course.

Quick example (careful, contrast hasn't been calculated, this is just a mockup)
image

@skjnldsv skjnldsv force-pushed the feat/tags-colors branch 5 times, most recently from 1f51a54 to c6bd30d Compare December 4, 2024 16:53
@skjnldsv skjnldsv requested review from jancborchardt, a team, susnux and artonge and removed request for a team December 4, 2024 17:01
@skjnldsv skjnldsv requested a review from szaimen December 4, 2024 17:01
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 4, 2024
@skjnldsv skjnldsv marked this pull request as ready for review December 4, 2024 19:12
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 6, 2024
@skjnldsv skjnldsv enabled auto-merge December 6, 2024 08:13
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit 9684c3d into master Dec 6, 2024
188 checks passed
@skjnldsv skjnldsv deleted the feat/tags-colors branch December 6, 2024 09:43
@disaster123
Copy link

Thanks a lot for this. What is the planend release Version?

@marcelklehr
Copy link
Member

@disaster123 Nextcloud 31 Hub 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement feature: tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colored tags
6 participants