From cb0f19f680525eba73326f54d4f3744e1be6ac68 Mon Sep 17 00:00:00 2001 From: Maksim Sukharev Date: Mon, 11 Nov 2024 18:13:21 +0100 Subject: [PATCH 1/2] chore(deps): bump @nextcloud/vue lib from 8.19.0 to 8.20.0 Signed-off-by: Maksim Sukharev --- package-lock.json | 34 +++++++++------------------------- package.json | 2 +- 2 files changed, 10 insertions(+), 26 deletions(-) diff --git a/package-lock.json b/package-lock.json index f97e94fdc4e..509a8a429ae 100644 --- a/package-lock.json +++ b/package-lock.json @@ -24,7 +24,7 @@ "@nextcloud/router": "^3.0.1", "@nextcloud/sharing": "^0.2.3", "@nextcloud/upload": "^1.6.1", - "@nextcloud/vue": "^8.19.0", + "@nextcloud/vue": "^8.20.0", "@vueuse/components": "^11.2.0", "@vueuse/core": "^11.2.0", "blurhash": "^2.0.5", @@ -3843,9 +3843,9 @@ } }, "node_modules/@nextcloud/vue": { - "version": "8.19.0", - "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.19.0.tgz", - "integrity": "sha512-mEawbIueee5fSGZreJV+/8h80SRriRTuib1UO9UWWEgqWvZQp0i99xXnIQj+UMw9AugxznJWd5R0ZOmZkN7p5w==", + "version": "8.20.0", + "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.20.0.tgz", + "integrity": "sha512-X8hsZGsJ4hRmPhTOZmpzXbHcXp4txvebIlRRos+Gm+nOESKTAaOqtMARHAk1f/B+WMULNCipQoNc1ef8AFLGZA==", "license": "AGPL-3.0-or-later", "dependencies": { "@floating-ui/dom": "^1.1.0", @@ -3865,7 +3865,7 @@ "@vueuse/components": "^11.0.0", "@vueuse/core": "^11.0.0", "clone": "^2.1.2", - "debounce": "2.1.1", + "debounce": "2.2.0", "dompurify": "^3.0.5", "emoji-mart-vue-fast": "^15.0.1", "escape-html": "^1.0.3", @@ -3942,17 +3942,6 @@ "url": "https://github.com/chalk/ansi-regex?sponsor=1" } }, - "node_modules/@nextcloud/vue/node_modules/debounce": { - "version": "2.1.1", - "resolved": "https://registry.npmjs.org/debounce/-/debounce-2.1.1.tgz", - "integrity": "sha512-+xRWxgel9LgTC4PwKlm7TJUK6B6qsEK77NaiNvXmeQ7Y3e6OVVsBC4a9BSptS/mAYceyAz37Oa8JTTuPRft7uQ==", - "engines": { - "node": ">=18" - }, - "funding": { - "url": "https://github.com/sponsors/sindresorhus" - } - }, "node_modules/@nextcloud/vue/node_modules/is-plain-obj": { "version": "4.1.0", "resolved": "https://registry.npmjs.org/is-plain-obj/-/is-plain-obj-4.1.0.tgz", @@ -23874,9 +23863,9 @@ } }, "@nextcloud/vue": { - "version": "8.19.0", - "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.19.0.tgz", - "integrity": "sha512-mEawbIueee5fSGZreJV+/8h80SRriRTuib1UO9UWWEgqWvZQp0i99xXnIQj+UMw9AugxznJWd5R0ZOmZkN7p5w==", + "version": "8.20.0", + "resolved": "https://registry.npmjs.org/@nextcloud/vue/-/vue-8.20.0.tgz", + "integrity": "sha512-X8hsZGsJ4hRmPhTOZmpzXbHcXp4txvebIlRRos+Gm+nOESKTAaOqtMARHAk1f/B+WMULNCipQoNc1ef8AFLGZA==", "requires": { "@floating-ui/dom": "^1.1.0", "@linusborg/vue-simple-portal": "^0.1.5", @@ -23895,7 +23884,7 @@ "@vueuse/components": "^11.0.0", "@vueuse/core": "^11.0.0", "clone": "^2.1.2", - "debounce": "2.1.1", + "debounce": "2.2.0", "dompurify": "^3.0.5", "emoji-mart-vue-fast": "^15.0.1", "escape-html": "^1.0.3", @@ -23950,11 +23939,6 @@ "resolved": "https://registry.npmjs.org/ansi-regex/-/ansi-regex-6.0.1.tgz", "integrity": "sha512-n5M855fKb2SsfMIiFFoVrABHJC8QtHwVx+mHWP3QcEqBHYienj5dHSgjbxtC0WEZXYt4wcD6zrQElDPhFuZgfA==" }, - "debounce": { - "version": "2.1.1", - "resolved": "https://registry.npmjs.org/debounce/-/debounce-2.1.1.tgz", - "integrity": "sha512-+xRWxgel9LgTC4PwKlm7TJUK6B6qsEK77NaiNvXmeQ7Y3e6OVVsBC4a9BSptS/mAYceyAz37Oa8JTTuPRft7uQ==" - }, "is-plain-obj": { "version": "4.1.0", "resolved": "https://registry.npmjs.org/is-plain-obj/-/is-plain-obj-4.1.0.tgz", diff --git a/package.json b/package.json index 9ec3fcb2fc6..8cd476afcf9 100644 --- a/package.json +++ b/package.json @@ -39,7 +39,7 @@ "@nextcloud/router": "^3.0.1", "@nextcloud/sharing": "^0.2.3", "@nextcloud/upload": "^1.6.1", - "@nextcloud/vue": "^8.19.0", + "@nextcloud/vue": "^8.20.0", "@vueuse/components": "^11.2.0", "@vueuse/core": "^11.2.0", "blurhash": "^2.0.5", From 81094e18f5ffce875f5322b9747fac0b1c321300 Mon Sep 17 00:00:00 2001 From: Maksim Sukharev Date: Fri, 1 Nov 2024 18:40:08 +0100 Subject: [PATCH 2/2] fix: adjust unsupported v-model usage Signed-off-by: Maksim Sukharev --- src/components/LeftSidebar/LeftSidebar.spec.js | 4 ++-- .../NewConversationSetupPage.vue | 12 ++++++------ 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/components/LeftSidebar/LeftSidebar.spec.js b/src/components/LeftSidebar/LeftSidebar.spec.js index c1e5c385d0c..8e1a941e3c0 100644 --- a/src/components/LeftSidebar/LeftSidebar.spec.js +++ b/src/components/LeftSidebar/LeftSidebar.spec.js @@ -642,7 +642,7 @@ describe('LeftSidebar.vue', () => { expect(ncModalComponent.exists()).toBeTruthy() const input = ncModalComponent.findComponent({ name: 'NcTextField', ref: 'conversationName' }) - expect(input.props('value')).toBe(groupsResults[1].label) + expect(input.props('modelValue')).toBe(groupsResults[1].label) // nothing created yet expect(createOneToOneConversationAction).not.toHaveBeenCalled() @@ -664,7 +664,7 @@ describe('LeftSidebar.vue', () => { const ncModalComponent = wrapper.findComponent({ name: 'NcModal' }) expect(ncModalComponent.exists()).toBeTruthy() const input = ncModalComponent.findComponent({ name: 'NcTextField', ref: 'conversationName' }) - expect(input.props('value')).toBe(circlesResults[1].label) + expect(input.props('modelValue')).toBe(circlesResults[1].label) // nothing created yet expect(createOneToOneConversationAction).not.toHaveBeenCalled() diff --git a/src/components/NewConversationDialog/NewConversationSetupPage.vue b/src/components/NewConversationDialog/NewConversationSetupPage.vue index fdfd14c309d..98a42c69a4b 100644 --- a/src/components/NewConversationDialog/NewConversationSetupPage.vue +++ b/src/components/NewConversationDialog/NewConversationSetupPage.vue @@ -115,8 +115,8 @@ export default { get() { return this.newConversation.displayName }, - set(event) { - this.updateNewConversation({ displayName: event.target.value }) + set(displayName) { + this.updateNewConversation({ displayName }) }, }, @@ -124,8 +124,8 @@ export default { get() { return this.newConversation.description }, - set(event) { - this.updateNewConversation({ description: event.target.value }) + set(description) { + this.updateNewConversation({ description }) }, }, @@ -172,8 +172,8 @@ export default { get() { return this.password }, - set(event) { - this.$emit('update:password', event.target.value) + set(value) { + this.$emit('update:password', value) }, },