Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display name is "null" after reload from being logged out #10535

Open
fancycode opened this issue Sep 19, 2023 · 2 comments
Open

Display name is "null" after reload from being logged out #10535

fancycode opened this issue Sep 19, 2023 · 2 comments
Labels

Comments

@fancycode
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

  1. Be in a room with a user account and close your laptop over night.
  2. Have your session expire while laptop is closed.
  3. Open your laptop, notice your signaling connection is not reconnected automatically and reload the page (now as anonymous guest user).

Expected behaviour

Display name should have a sensible default value.

Actual behaviour

displayname_null

Experienced on c.n.c in the Talk development room.

@nickvergessen
Copy link
Member

nickvergessen commented Sep 19, 2023

cc @DorraJaouad since you touched the guest names maybe for #10467 - master only

UPD.: this could be triggers for this issue:

@DorraJaouad
Copy link
Contributor

DorraJaouad commented Sep 23, 2023

There is a "Guest" string as a fallback if the getter getDisplayName() returns null.
Will be further checking ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants