Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow-up(PublicShareAuthSidebar): sidebar doesn't track conversation removal #10723

Open
Antreesy opened this issue Oct 17, 2023 · 0 comments
Open
Labels
1. to develop bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents

Comments

@Antreesy
Copy link
Contributor

Antreesy commented Oct 17, 2023

When requesting the password of a share it might be good to leave the room if the media settings screen is closed without joining the call. Leaving the call or the conversation should update the sidebar and remove the call view and the chat and show This conversation has ended, although it seems that was lost at some point 🤔 As leaving the call does not currently do that I guess it would be fine to leave the conversation when the media settings is closed in a follow up once the existing code was also fixed.

Originally posted by @danxuliu in #10633 (review)

With internal signling only, we fetch conversation within an interval, and show the context mentioned above.
With HPB setup sidebar waits for signaling message to fetch.

As a solution - we may track signaling message, that owner left the room, and fetch the conversation within some timeout => and if it was deleted, it should show This conversation has ended

@Antreesy Antreesy added 1. to develop bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents labels Oct 17, 2023
@Antreesy Antreesy added this to the 💙 Next Major (28) milestone Oct 17, 2023
@Antreesy Antreesy changed the title follow-up(PublicShareAuthSidebar) follow-up(PublicShareAuthSidebar): sidebar doesn't track conversation removal Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents
Projects
None yet
Development

No branches or pull requests

3 participants