Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up(Edit message) #11403

Closed
8 of 9 tasks
DorraJaouad opened this issue Jan 18, 2024 · 9 comments · Fixed by #11451
Closed
8 of 9 tasks

Follow-up(Edit message) #11403

DorraJaouad opened this issue Jan 18, 2024 · 9 comments · Fixed by #11451

Comments

@DorraJaouad
Copy link
Contributor

DorraJaouad commented Jan 18, 2024

Follow-up to #11374

To do 🚧

@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Jan 23, 2024

@nextcloud/designers, could you please share some feedback on these points:

  • The hint "Adding a mention ..." will be a NcNoteCard. Is it okay in terms of the spacing ? It is not shown only if a user edits a message and add a mention.
  • "Last edit info" design in MessageButtonsBar
  • Should the edit message button be moved above delete button ?
    image

You can refer to #11374 for the basic edit feature screenshots

@szaimen
Copy link
Contributor

szaimen commented Jan 24, 2024

  • The hint "Adding a mention ..." will be a NcNoteCard. Is it okay in terms of the spacing ? It is not shown only if a user edits a message and add a mention.

I don't see this on the screenshot, do I see it somewhere?

  • "Last edit info" design in MessageButtonsBar

Looks good but I would show the time before the date...

  • Should the edit message button be moved above delete button ?

It is alreaddy above it in the screenshot?

@DorraJaouad
Copy link
Contributor Author

I don't see this on the screenshot, do I see it somewhere?

It's the yellow line
image

It is alreaddy above it in the screenshot?

Currently, it is here
image

@jancborchardt
Copy link
Member

I don't see this on the screenshot, do I see it somewhere?

It's the yellow line image

This doesn’t look like NcNoteCard though? If it would be NcNoteCard then it would be fine. :)


It is alreaddy above it in the screenshot?

Currently, it is here image

This seems good to me, however the detail list as per this screenshot could be improved. There is strange spacing between the nickname and the time. We would probably have to make it 2-line, so that it’s "Edited by Simon Lindner" in the first line (as we shouldn’t just show account names there and they might be long) and the date in the subline
image

Similar to how it is on iOS as per the comment #11203 (comment)
image

@DorraJaouad
Copy link
Contributor Author

DorraJaouad commented Jan 25, 2024

Currently, the author+timestamp line is like this :
image

The line will expand depending on the username length.

so that it’s "Edited by Simon Lindner" in the first line (as we shouldn’t just show account names there and they might be long) and the date in the subline

I am worried that it will be a bit confusing to see 2 dates and each is on a line ( sent timestamp and edited timestamp). There should be way to distinguish between them (like change the edited stamp text color to secondary ?) .

@nickvergessen
Copy link
Member

Currently, the author+timestamp line is like this :

Can you use a "real name" as sample in the screenshot so we see it wrap (rebasing on latest master should give you the display name)

@jancborchardt
Copy link
Member

I am worried that it will be a bit confusing to see 2 dates and each is on a line ( sent timestamp and edited timestamp). There should be way to distinguish between them (like change the edited stamp text color to secondary ?) .

Sure, sounds good! :) Then let's indeed use colore-text-maxcontrast for the timestamp of any edits (not for the main timestamp), and also separate the name and timestamp with a middle dot like so:

Simon Lindner · Jan 17, 2024 3:42 PM

@DorraJaouad
Copy link
Contributor Author

Option 1 (as iOS shows only time, and you can edit within 24 hours)

|image |image|

Option 2
image|image

@SystemKeeper
Copy link
Contributor

Option 1 (as iOS shows only time, and you can edit within 24 hours)

Just for clarification, iOS shows the time only when it happened today, otherwise it shows date and time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants