Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overwriting capability setting does not invalide proxy hash #11865

Closed
SystemKeeper opened this issue Mar 19, 2024 · 1 comment · Fixed by #11900
Closed

Overwriting capability setting does not invalide proxy hash #11865

SystemKeeper opened this issue Mar 19, 2024 · 1 comment · Fixed by #11900
Assignees
@nickvergessen
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐
Milestone
v19.0.0-beta.5

Comments

@SystemKeeper
Copy link
Contributor

In #11846 we started overwriting some of the remote capabilities. As this is done after setting the proxy-hash, it will not change the provided proxy-hash. That means for everything we introduce/change in later versions of Talk, clients will not refetch the room capabilities.
@nickvergessen nickvergessen added this to the 💞 Next Beta (29) milestone Mar 22, 2024
@nickvergessen nickvergessen moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 💬 Talk team Mar 22, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Mar 22, 2024
@nickvergessen nickvergessen mentioned this issue Mar 22, 2024
Merged
3 tasks
@nickvergessen nickvergessen self-assigned this Mar 22, 2024
@nickvergessen
Copy link
Member

That means for everything we introduce/change in later versions of Talk, clients will not refetch the room capabilities.

Since the Talk version is part of the hash as well, I guess it would have worked already, but added it never the less

@nickvergessen nickvergessen moved this from 📄 To do (~10 entries) to 🏗️ In progress in 💬 Talk team Mar 22, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 💬 Talk team Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickvergessen nickvergessen

Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐
Projects
💬 Talk team
Archived in project
Milestone
v19.0.0-beta.5
Development

Successfully merging a pull request may close this issue.

fix(federation): Change the Talk-Hash header when overwriting capabil… nextcloud/spreed
2 participants
@nickvergessen @SystemKeeper