Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signaling: Improve error handling when joining a room #12750

Open
fancycode opened this issue Jul 18, 2024 · 0 comments
Open

signaling: Improve error handling when joining a room #12750

fancycode opened this issue Jul 18, 2024 · 0 comments
Labels
1. to develop bug feature: frontend 🖌️ "Web UI" client feature: signaling 📶 Internal and external signaling backends

Comments

@fancycode
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

If joining a room fails, the error is currently not handled:

console.debug('Joined', data, token)

The join request is not retried or the error otherwise handled, so the signaling server will close the session if it's an anonymous user and disconnect the websocket:
https://github.com/strukturag/nextcloud-spreed-signaling/blob/98bf947ce36657b58b815c997805fe9cb7bf8471/hub.go#L664

This will trigger a reconnect in the client which tries to resume the (already deleted) session.

@danxuliu I noticed this while testing #12604 where errors while joining can happen much more often than normally.

@nickvergessen nickvergessen added this to the Delayed milestone Nov 21, 2024
@nickvergessen nickvergessen modified the milestones: Delayed, 🖤 Next Major (31) Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug feature: frontend 🖌️ "Web UI" client feature: signaling 📶 Internal and external signaling backends
Projects
None yet
Development

No branches or pull requests

5 participants