Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NewConversationDialog): speed up conversation creation flow #12431

Merged
merged 3 commits into from
May 28, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix Participant list is only displayed after some time #12206
  • Only createConversation is mandatory to be completed first, rest request are secondary and could be done in parallel
  • As owner of conversation definitely has all needed permissions and access to the conversation, we can fetch participants list (with statuses, permissions, e.t.c) much earlier
    • we don't need to wait to join conversation
    • we're the only one in the conversation yet, so don't need to debounce request (up to 3-15 sec)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

Testing the time (with local server) from submitting the form with following:

  • Description
  • Avatar
  • Password
  • Listable
  • 5 participants

to the time participants are fetched

🏚️ Before 🏡 After
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Antreesy added 3 commits May 28, 2024 16:56
…ethods

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…le try-catch block, run in parallel

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy force-pushed the fix/12206/speed-up-new-conversation branch from e0bed42 to 7f4b551 Compare May 28, 2024 15:13
@ShGKme
Copy link
Contributor

ShGKme commented May 28, 2024

cc @nickvergessen
It seems we need too many requests to create a conversation. Can we add a new entrypoint / extend existing to do everything in one/two requests instead 5 + n where N is the number of participants?

@Antreesy Antreesy merged commit 29e65da into main May 28, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/12206/speed-up-new-conversation branch May 28, 2024 17:06
@Antreesy
Copy link
Contributor Author

Antreesy commented Jun 5, 2024

Can we add a new entrypoint / extend existing

Previous discussion in #2874

@Antreesy
Copy link
Contributor Author

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Participant list is only displayed after some time
2 participants