-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NewConversationDialog): speed up conversation creation flow #12431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
reviewed
May 28, 2024
src/components/ConversationSettings/ConversationAvatarEditor.vue
Outdated
Show resolved
Hide resolved
ShGKme
reviewed
May 28, 2024
…ethods Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
…le try-catch block, run in parallel Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
e0bed42
to
7f4b551
Compare
ShGKme
approved these changes
May 28, 2024
cc @nickvergessen |
Previous discussion in #2874 |
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
createConversation
is mandatory to be completed first, rest request are secondary and could be done in parallel🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Testing the time (with local server) from submitting the form with following:
to the time participants are fetched
🏁 Checklist