From a2ef4bcb86902f988b3525e5c609caf01daaec06 Mon Sep 17 00:00:00 2001
From: Florian Steffens <florian.steffens@nextcloud.com>
Date: Wed, 13 Sep 2023 22:52:43 +0200
Subject: [PATCH] fix(design): fix loading the default column-link providers -
 add configuration to avoid saving incorrect column configs - add info cards
 if no providers are chosen

Signed-off-by: Florian Steffens <florian.steffens@nextcloud.com>
---
 src/modules/modals/EditColumn.vue             |  9 ++--
 .../forms/DatetimeDateForm.vue                |  4 ++
 .../columnTypePartials/forms/DatetimeForm.vue |  4 ++
 .../forms/DatetimeTimeForm.vue                |  4 ++
 .../columnTypePartials/forms/NumberForm.vue   |  4 ++
 .../forms/NumberProgressForm.vue              |  4 ++
 .../forms/NumberStarsForm.vue                 |  4 ++
 .../forms/SelectionCheckForm.vue              |  4 ++
 .../forms/SelectionForm.vue                   |  4 ++
 .../forms/SelectionMultiForm.vue              |  4 ++
 .../columnTypePartials/forms/TextLineForm.vue |  4 ++
 .../columnTypePartials/forms/TextLinkForm.vue | 29 ++++++++++--
 .../columnTypePartials/forms/TextLongForm.vue |  4 ++
 .../columnTypePartials/forms/TextRichForm.vue |  4 ++
 .../partials/rowTypePartials/TextLinkForm.vue | 44 ++++++++++++-------
 15 files changed, 108 insertions(+), 22 deletions(-)

diff --git a/src/modules/modals/EditColumn.vue b/src/modules/modals/EditColumn.vue
index b05e0a6aa..8b1348f46 100644
--- a/src/modules/modals/EditColumn.vue
+++ b/src/modules/modals/EditColumn.vue
@@ -18,7 +18,7 @@
 						:title-missing-error="editErrorTitle" />
 				</div>
 				<div class="col-2 space-LR space-T">
-					<component :is="getColumnForm" :column="editColumn" />
+					<component :is="getColumnForm" :column="editColumn" :can-save.sync="canSave" />
 				</div>
 			</div>
 			<div class="buttons">
@@ -36,7 +36,7 @@
 							{{ t('tables', 'Cancel') }}
 						</NcButton>
 					</div>
-					<NcButton type="primary" :aria-label="t('tables', 'Save')" @click="saveColumn">
+					<NcButton type="primary" :aria-label="t('tables', 'Save')" :disabled="!canSave" @click="saveColumn">
 						{{ t('tables', 'Save') }}
 					</NcButton>
 				</div>
@@ -108,9 +108,10 @@ export default {
 	data() {
 		return {
 			loading: false,
-			editColumn: structuredClone(this.column),
+			editColumn: Object.assign({}, this.column),
 			deleteId: null,
 			editErrorTitle: false,
+			canSave: true, // avoid to save an incorrect config
 		}
 	},
 	computed: {
@@ -165,7 +166,7 @@ export default {
 			this.editErrorTitle = false
 		},
 		async updateColumn() {
-			const data = { ...this.editColumn }
+			const data = Object.assign({}, this.editColumn)
 			if ((this.column.type === ColumnTypes.SelectionMulti || this.column.type === ColumnTypes.SelectionCheck) && data.selectionDefault !== null) data.selectionDefault = JSON.stringify(data.selectionDefault)
 			delete data.type
 			delete data.id
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeDateForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeDateForm.vue
index 974e5a75a..5d294db43 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeDateForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeDateForm.vue
@@ -26,6 +26,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeForm.vue
index 22cafa3b8..e206aa08e 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeForm.vue
@@ -23,6 +23,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeTimeForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeTimeForm.vue
index 686f33496..fbbef57b5 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeTimeForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/DatetimeTimeForm.vue
@@ -23,6 +23,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberForm.vue
index af59e2a60..d27a11bbb 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberForm.vue
@@ -75,6 +75,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberProgressForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberProgressForm.vue
index 696030e32..aab7a952d 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberProgressForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberProgressForm.vue
@@ -26,6 +26,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberStarsForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberStarsForm.vue
index 4c9d211d6..3c9efea6b 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberStarsForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/NumberStarsForm.vue
@@ -44,6 +44,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionCheckForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionCheckForm.vue
index 0a15aed6a..1de8b3eac 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionCheckForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionCheckForm.vue
@@ -26,6 +26,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionForm.vue
index 5cb75da72..f1d6a060a 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionForm.vue
@@ -41,6 +41,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionMultiForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionMultiForm.vue
index 0266cb076..f1d8f9cff 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionMultiForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/SelectionMultiForm.vue
@@ -40,6 +40,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLineForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLineForm.vue
index a7c98f8e4..8327bf02b 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLineForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLineForm.vue
@@ -48,6 +48,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 
 	data() {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLinkForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLinkForm.vue
index a6dedc34a..1c74af956 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLinkForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLinkForm.vue
@@ -7,6 +7,11 @@
 			<div class="fix-col-4">
 				{{ t('tables', 'Allowed types') }}
 			</div>
+			<div v-if="!canSave" class="fix-col-4">
+				<NcNoteCard type="warning">
+					{{ t('tables', 'Please select at least one provider.') }}
+				</NcNoteCard>
+			</div>
 			<div class="col-4 space-B typeSelection">
 				<NcCheckboxRadioSwitch v-for="provider in getProviders" :key="provider.id" :checked.sync="provider.active" type="switch">
 					{{ provider.label }}
@@ -20,7 +25,7 @@
 </template>
 
 <script>
-import { NcCheckboxRadioSwitch } from '@nextcloud/vue'
+import { NcCheckboxRadioSwitch, NcNoteCard } from '@nextcloud/vue'
 import axios from '@nextcloud/axios'
 import displayError from '../../../../../utils/displayError.js'
 import { generateOcsUrl } from '@nextcloud/router'
@@ -30,12 +35,17 @@ export default {
 
 	components: {
 		NcCheckboxRadioSwitch,
+		NcNoteCard,
 	},
 	props: {
 		column: {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
@@ -60,11 +70,24 @@ export default {
 			})
 			return activeProviderIds
 		},
+		error: {
+			get() {
+				return !this.canSave
+			},
+			set(v) {
+				this.$emit('update:can-save', !v)
+			},
+		},
 	},
 
 	watch: {
 		getSelectedProviderIds() {
 			this.mutableColumn.textAllowedPattern = this.getSelectedProviderIds.join(',')
+			if (this.getSelectedProviderIds.length === 0) {
+				this.error = true
+			} else {
+				this.error = false
+			}
 		},
 		column() {
 			this.mutableColumn = this.column
@@ -108,8 +131,8 @@ export default {
 			})
 		},
 		isActive(providerId) {
-			if (this.column.textAllowedPattern) {
-				const selectedProviders = this.column.textAllowedPattern.split(',')
+			if (this.column?.id) {
+				const selectedProviders = this.column.textAllowedPattern?.split(',')
 				return selectedProviders.indexOf(providerId) !== -1
 			} else {
 				return this.preActivatedProviders.indexOf(providerId) !== -1
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLongForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLongForm.vue
index c6bfb1166..85e95f7fb 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLongForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/TextLongForm.vue
@@ -36,6 +36,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/columnTypePartials/forms/TextRichForm.vue b/src/shared/components/ncTable/partials/columnTypePartials/forms/TextRichForm.vue
index dce48f097..9fdfd94bc 100644
--- a/src/shared/components/ncTable/partials/columnTypePartials/forms/TextRichForm.vue
+++ b/src/shared/components/ncTable/partials/columnTypePartials/forms/TextRichForm.vue
@@ -26,6 +26,10 @@ export default {
 			type: Object,
 			default: null,
 		},
+		canSave: {
+			type: Boolean,
+			default: true,
+		},
 	},
 	data() {
 		return {
diff --git a/src/shared/components/ncTable/partials/rowTypePartials/TextLinkForm.vue b/src/shared/components/ncTable/partials/rowTypePartials/TextLinkForm.vue
index 998412e88..e421844b2 100644
--- a/src/shared/components/ncTable/partials/rowTypePartials/TextLinkForm.vue
+++ b/src/shared/components/ncTable/partials/rowTypePartials/TextLinkForm.vue
@@ -1,18 +1,27 @@
 <template>
 	<RowFormWrapper :title="column.title" :mandatory="column.mandatory" :description="column.description" :loading="isLoadingResults">
-		<NcSelect v-model="localValue"
-			:options="results"
-			:clearable="true"
-			label="title"
-			style="width: 100%"
-			@search="v => term = v">
-			<template #option="props">
-				<LinkWidget :thumbnail-url="props.thumbnailUrl" :icon-url="props.icon" :title="props.title" :subline="props.subline" :icon-size="40" />
-			</template>
-			<template #selected-option="props">
-				<LinkWidget :thumbnail-url="props.thumbnailUrl" :icon-url="props.icon" :title="props.title" :subline="props.subline" :icon-size="40" />
-			</template>
-		</NcSelect>
+		<div class="row">
+			<div v-if="providers.length === 0" class="col-4">
+				<NcNoteCard type="info">
+					{{ t('tables', 'You can not insert any links in this field. Please configure at least one link provider in the column configuration.') }}
+				</NcNoteCard>
+			</div>
+			<div class="col-4">
+				<NcSelect v-model="localValue"
+					:options="results"
+					:clearable="true"
+					label="title"
+					style="width: 100%"
+					@search="v => term = v">
+					<template #option="props">
+						<LinkWidget :thumbnail-url="props.thumbnailUrl" :icon-url="props.icon" :title="props.title" :subline="props.subline" :icon-size="40" />
+					</template>
+					<template #selected-option="props">
+						<LinkWidget :thumbnail-url="props.thumbnailUrl" :icon-url="props.icon" :title="props.title" :subline="props.subline" :icon-size="40" />
+					</template>
+				</NcSelect>
+			</div>
+		</div>
 	</RowFormWrapper>
 </template>
 
@@ -21,7 +30,7 @@ import RowFormWrapper from './RowFormWrapper.vue'
 import axios from '@nextcloud/axios'
 import { generateOcsUrl } from '@nextcloud/router'
 import displayError from '../../../../utils/displayError.js'
-import { NcSelect } from '@nextcloud/vue'
+import { NcNoteCard, NcSelect } from '@nextcloud/vue'
 import debounce from 'debounce'
 import generalHelper from '../../../../mixins/generalHelper.js'
 import LinkWidget from '../LinkWidget.vue'
@@ -30,6 +39,7 @@ import { translate as t } from '@nextcloud/l10n'
 export default {
 
 	components: {
+		NcNoteCard,
 		RowFormWrapper,
 		NcSelect,
 		LinkWidget,
@@ -104,7 +114,11 @@ export default {
 	},
 
 	mounted() {
-		this.providers = this.column?.textAllowedPattern?.split(',')
+		if (this.column?.textAllowedPattern) {
+			this.providers = this.column?.textAllowedPattern?.split(',')
+		} else {
+			this.providers = []
+		}
 	},
 
 	methods: {